chrome/browser/ui/views/toolbar/app_menu.cc - Issue 2424853003: Remove FOR_EACH_OBSERVER macro usage in chrome/browser/ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/app_menu.cc

Issue 2424853003: Remove FOR_EACH_OBSERVER macro usage in chrome/browser/ui (Closed)

Patch Set: explicit types Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/toolbar/app_menu.cc

diff --git a/chrome/browser/ui/views/toolbar/app_menu.cc b/chrome/browser/ui/views/toolbar/app_menu.cc

index 45f98c66509ebbbe1f8fb17240aa95807a8a1e34..5547f62ad39a32eb43e95858ee1efe0138f69869 100644

--- a/chrome/browser/ui/views/toolbar/app_menu.cc

+++ b/chrome/browser/ui/views/toolbar/app_menu.cc

@@ -800,7 +800,8 @@ AppMenu::~AppMenu() {

if (model)

model->RemoveObserver(this);

}

- FOR_EACH_OBSERVER(AppMenuObserver, observer_list_, AppMenuDestroyed());

+ for (AppMenuObserver& observer : observer_list_)

+ observer.AppMenuDestroyed();

}

void AppMenu::Init(ui::MenuModel* model) {