chrome/browser/ui/views/website_settings/permission_selector_row.cc - Issue 2424853003: Remove FOR_EACH_OBSERVER macro usage in chrome/browser/ui

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/website_settings/permission_selector_row.cc

Issue 2424853003: Remove FOR_EACH_OBSERVER macro usage in chrome/browser/ui (Closed)

Patch Set: explicit types Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/views/website_settings/chosen_object_row.cc ('k') | chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/views/website_settings/permission_selector_row.h"	5 #include "chrome/browser/ui/views/website_settings/permission_selector_row.h"

6	6

7 #include "base/i18n/rtl.h"	7 #include "base/i18n/rtl.h"

8 #include "base/macros.h"	8 #include "base/macros.h"

9 #include "base/strings/utf_string_conversions.h"	9 #include "base/strings/utf_string_conversions.h"

10 #include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h "	10 #include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h "

(...skipping 348 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
359 if (menu_button_) {	359 if (menu_button_) {

360 menu_button_->SetText(WebsiteSettingsUI::PermissionActionToUIString(	360 menu_button_->SetText(WebsiteSettingsUI::PermissionActionToUIString(

361 profile_, permission.type, permission.setting,	361 profile_, permission.type, permission.setting,

362 permission.default_setting, content_settings::SETTING_SOURCE_USER));	362 permission.default_setting, content_settings::SETTING_SOURCE_USER));

363 menu_button_->SizeToPreferredSize();	363 menu_button_->SizeToPreferredSize();

364 } else if (combobox_) {	364 } else if (combobox_) {

365 bool use_default = permission.setting == CONTENT_SETTING_DEFAULT;	365 bool use_default = permission.setting == CONTENT_SETTING_DEFAULT;

366 combobox_->UpdateSelectedIndex(use_default);	366 combobox_->UpdateSelectedIndex(use_default);

367 }	367 }

368	368

369 FOR_EACH_OBSERVER(PermissionSelectorRowObserver,	369 for (PermissionSelectorRowObserver& observer : observer_list_)

370 observer_list_,	370 observer.OnPermissionChanged(permission);

371 OnPermissionChanged(permission));

372 }	371 }

OLD	NEW