Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8256)

Unified Diff: chrome/browser/ui/browser_list.cc

Issue 2424853003: Remove FOR_EACH_OBSERVER macro usage in chrome/browser/ui (Closed)
Patch Set: explicit types Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_list.cc
diff --git a/chrome/browser/ui/browser_list.cc b/chrome/browser/ui/browser_list.cc
index 6222fbeee74371127c0f847d039af38cb33ab67e..74260b4be30b5aebefe0d0c5ce67ea3b75862136 100644
--- a/chrome/browser/ui/browser_list.cc
+++ b/chrome/browser/ui/browser_list.cc
@@ -61,8 +61,8 @@ void BrowserList::AddBrowser(Browser* browser) {
content::Source<Browser>(browser),
content::NotificationService::NoDetails());
- FOR_EACH_OBSERVER(chrome::BrowserListObserver, observers_.Get(),
- OnBrowserAdded(browser));
+ for (chrome::BrowserListObserver& observer : observers_.Get())
+ observer.OnBrowserAdded(browser);
}
// static
@@ -78,8 +78,8 @@ void BrowserList::RemoveBrowser(Browser* browser) {
RemoveBrowserFrom(browser, &browser_list->browsers_);
- FOR_EACH_OBSERVER(chrome::BrowserListObserver, observers_.Get(),
- OnBrowserRemoved(browser));
+ for (chrome::BrowserListObserver& observer : observers_.Get())
+ observer.OnBrowserRemoved(browser);
browser->UnregisterKeepAlive();
@@ -216,8 +216,8 @@ void BrowserList::MoveBrowsersInWorkspaceToFront(
Browser* new_last_active = instance->GetLastActive();
if (old_last_active != new_last_active) {
- FOR_EACH_OBSERVER(chrome::BrowserListObserver, observers_.Get(),
- OnBrowserSetLastActive(new_last_active));
+ for (chrome::BrowserListObserver& observer : observers_.Get())
+ observer.OnBrowserSetLastActive(new_last_active);
}
}
@@ -228,14 +228,14 @@ void BrowserList::SetLastActive(Browser* browser) {
RemoveBrowserFrom(browser, &GetInstance()->last_active_browsers_);
GetInstance()->last_active_browsers_.push_back(browser);
- FOR_EACH_OBSERVER(chrome::BrowserListObserver, observers_.Get(),
- OnBrowserSetLastActive(browser));
+ for (chrome::BrowserListObserver& observer : observers_.Get())
+ observer.OnBrowserSetLastActive(browser);
}
// static
void BrowserList::NotifyBrowserNoLongerActive(Browser* browser) {
- FOR_EACH_OBSERVER(chrome::BrowserListObserver, observers_.Get(),
- OnBrowserNoLongerActive(browser));
+ for (chrome::BrowserListObserver& observer : observers_.Get())
+ observer.OnBrowserNoLongerActive(browser);
}
// static
« no previous file with comments | « chrome/browser/ui/bookmarks/recently_used_folders_combo_model.cc ('k') | chrome/browser/ui/ime/ime_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698