chrome/browser/ui/libgtk2ui/gtk2_ui.cc - Issue 2424853003: Remove FOR_EACH_OBSERVER macro usage in chrome/browser/ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/libgtk2ui/gtk2_ui.cc

Issue 2424853003: Remove FOR_EACH_OBSERVER macro usage in chrome/browser/ui (Closed)

Patch Set: explicit types Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/libgtk2ui/gtk2_ui.cc

diff --git a/chrome/browser/ui/libgtk2ui/gtk2_ui.cc b/chrome/browser/ui/libgtk2ui/gtk2_ui.cc

index 1286923e796e11b01231d7c27ec33446cb8d04b1..415b99a445270b101b8298cd887c9d8260e2be90 100644

--- a/chrome/browser/ui/libgtk2ui/gtk2_ui.cc

+++ b/chrome/browser/ui/libgtk2ui/gtk2_ui.cc

@@ -717,9 +717,8 @@ void Gtk2UI::SetWindowButtonOrdering(

leading_buttons_ = leading_buttons;

trailing_buttons_ = trailing_buttons;

- FOR_EACH_OBSERVER(views::WindowButtonOrderObserver, observer_list_,

- OnWindowButtonOrderingChange(leading_buttons_,

- trailing_buttons_));

+ for (views::WindowButtonOrderObserver& observer : observer_list_)

+ observer.OnWindowButtonOrderingChange(leading_buttons_, trailing_buttons_);

}

void Gtk2UI::SetNonClientMiddleClickAction(NonClientMiddleClickAction action) {

« no previous file with comments | « chrome/browser/ui/ime/ime_window.cc ('k') | chrome/browser/ui/search/search_model.cc » ('j') | no next file with comments »