Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc

Issue 2424853003: Remove FOR_EACH_OBSERVER macro usage in chrome/browser/ui (Closed)
Patch Set: explicit types Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.h" 5 #include "chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.h"
6 6
7 #include "chrome/browser/chromeos/login/ui/webui_login_display.h" 7 #include "chrome/browser/chromeos/login/ui/webui_login_display.h"
8 #include "chrome/browser/chromeos/options/network_config_view.h" 8 #include "chrome/browser/chromeos/options/network_config_view.h"
9 #include "chrome/browser/chromeos/ui/choose_mobile_network_dialog.h" 9 #include "chrome/browser/chromeos/ui/choose_mobile_network_dialog.h"
10 #include "chrome/browser/ui/webui/chromeos/login/network_dropdown.h" 10 #include "chrome/browser/ui/webui/chromeos/login/network_dropdown.h"
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 gfx::NativeWindow native_window = GetNativeWindow(); 82 gfx::NativeWindow native_window = GetNativeWindow();
83 NetworkConfigView::ShowForType(shill::kTypeWifi, native_window); 83 NetworkConfigView::ShowForType(shill::kTypeWifi, native_window);
84 } 84 }
85 85
86 void NetworkDropdownHandler::HandleLaunchAddMobileNetworkDialog() { 86 void NetworkDropdownHandler::HandleLaunchAddMobileNetworkDialog() {
87 gfx::NativeWindow native_window = GetNativeWindow(); 87 gfx::NativeWindow native_window = GetNativeWindow();
88 ChooseMobileNetworkDialog::ShowDialog(native_window); 88 ChooseMobileNetworkDialog::ShowDialog(native_window);
89 } 89 }
90 90
91 void NetworkDropdownHandler::OnConnectToNetworkRequested() { 91 void NetworkDropdownHandler::OnConnectToNetworkRequested() {
92 FOR_EACH_OBSERVER(Observer, observers_, OnConnectToNetworkRequested()); 92 for (Observer& observer : observers_)
93 observer.OnConnectToNetworkRequested();
93 } 94 }
94 95
95 void NetworkDropdownHandler::HandleNetworkItemChosen(double id) { 96 void NetworkDropdownHandler::HandleNetworkItemChosen(double id) {
96 if (dropdown_.get()) { 97 if (dropdown_.get()) {
97 dropdown_->OnItemChosen(static_cast<int>(id)); 98 dropdown_->OnItemChosen(static_cast<int>(id));
98 } else { 99 } else {
99 // It could happen with very low probability but still keep NOTREACHED to 100 // It could happen with very low probability but still keep NOTREACHED to
100 // detect if it starts happening all the time. 101 // detect if it starts happening all the time.
101 NOTREACHED(); 102 NOTREACHED();
102 } 103 }
(...skipping 10 matching lines...) Expand all
113 } 114 }
114 115
115 void NetworkDropdownHandler::HandleNetworkDropdownRefresh() { 116 void NetworkDropdownHandler::HandleNetworkDropdownRefresh() {
116 // Since language change is async, 117 // Since language change is async,
117 // we may in theory be on another screen during this call. 118 // we may in theory be on another screen during this call.
118 if (dropdown_.get()) 119 if (dropdown_.get())
119 dropdown_->Refresh(); 120 dropdown_->Refresh();
120 } 121 }
121 122
122 } // namespace chromeos 123 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698