Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2394683005: Remove ASSERT_UNUSED (Closed)

Created:
4 years, 2 months ago by tkent
Modified:
4 years, 2 months ago
Reviewers:
Yuta Kitamura
CC:
aboxhall, aboxhall+watch_chromium.org, Mads Ager (chromium), ajuma+watch_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-events_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-style_chromium.org, blink-reviews-wtf_chromium.org, Rik, caseq+blink_chromium.org, chromium-reviews, cmumford, danakj+watch_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, dmazzoni+watch_chromium.org, dmazzoni, dshwang, drott+blinkwatch_chromium.org, krit, dtapuska+blinkwatch_chromium.org, dtseng+watch_chromium.org, eae+blinkwatch, Eric Willigers, f(malita), fs, gyuyoung2, haraken, jbroman, jchaffraix+rendering, je_julie, jsbell+idb_chromium.org, Justin Novosad, kinuko+watch, kinuko+fileapi, kouhei+svg_chromium.org, kouhei+heap_chromium.org, kozyatinskiy+blink_chromium.org, leviw+renderwatch, loading-reviews+parser_chromium.org, lushnikov+blink_chromium.org, mcasas+watch+mediastream_chromium.org, Mikhail, mlamouri+watch-blink_chromium.org, nektar+watch_chromium.org, nektarios, nhiroki, oilpan-reviews, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, pfeldman+blink_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, szager+layoutwatch_chromium.org, timvolodine, tommyw+watchlist_chromium.org, tzik, yuzo+watch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ASSERT_UNUSED This CL has no behavior changes. BUG=596760 Committed: https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2 Cr-Commit-Position: refs/heads/master@{#423519}

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -112 lines) Patch
M third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl View 2 chunks +2 lines, -2 lines 2 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/PlatformEventController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLEntityParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/FloatingObjects.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCol.cpp View 1 chunk +9 lines, -6 lines 3 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableRow.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeMac.mm View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/EventSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/PagePopupController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/FileWriterSync.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/DateComponents.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/mac/FontCacheMac.mm View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamCenter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/SegmentedString.h View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp View 4 chunks +7 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/web/AssociatedURLLoader.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Assertions.h View 3 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/wtf/ThreadRestrictionVerifier.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/ThreadingPthreads.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/wtf/ThreadingWin.cpp View 6 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (14 generated)
tkent
yutak@, would you review this please?
4 years, 2 months ago (2016-10-06 10:34:52 UTC) #11
Yuta Kitamura
LGTM, I just have nit-ty comments. https://codereview.chromium.org/2394683005/diff/20001/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl File third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl (right): https://codereview.chromium.org/2394683005/diff/20001/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl#newcode844 third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl:844: DCHECK(associatedWrapper == object); ...
4 years, 2 months ago (2016-10-06 10:50:04 UTC) #12
tkent
https://codereview.chromium.org/2394683005/diff/20001/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl File third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl (right): https://codereview.chromium.org/2394683005/diff/20001/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl#newcode844 third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl:844: DCHECK(associatedWrapper == object); On 2016/10/06 at 10:50:04, Yuta Kitamura ...
4 years, 2 months ago (2016-10-06 14:07:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394683005/20001
4 years, 2 months ago (2016-10-06 14:08:12 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-10-06 14:16:08 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 14:18:10 UTC) #20
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/808f09ae9b773d69c271aedd63157b2b020cd0a2
Cr-Commit-Position: refs/heads/master@{#423519}

Powered by Google App Engine
This is Rietveld 408576698