third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp - Issue 2394683005: Remove ASSERT_UNUSED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp

Issue 2394683005: Remove ASSERT_UNUSED (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp

diff --git a/third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp b/third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp

index 8664fe523e27810d196f8a045ce8ca635998ae7b..d775a0bde5d5afcd870365b8f30d2818e7822cfb 100644

--- a/third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp

+++ b/third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp

@@ -134,7 +134,7 @@ void ColorChooserPopupUIController::setValue(const String& value) {

DCHECK(m_client);

Color color;

bool success = color.setFromString(value);

- ASSERT_UNUSED(success, success);

+ DCHECK(success);

m_client->didChooseColor(color);

}