Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Unified Diff: third_party/WebKit/Source/web/AssociatedURLLoader.cpp

Issue 2394683005: Remove ASSERT_UNUSED (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/AssociatedURLLoader.cpp
diff --git a/third_party/WebKit/Source/web/AssociatedURLLoader.cpp b/third_party/WebKit/Source/web/AssociatedURLLoader.cpp
index 3e3c52e7884bd257800d269fa1942aec36fe88a6..afa383855651aee3731f832689eca4e79507cc34 100644
--- a/third_party/WebKit/Source/web/AssociatedURLLoader.cpp
+++ b/third_party/WebKit/Source/web/AssociatedURLLoader.cpp
@@ -190,7 +190,7 @@ void AssociatedURLLoader::ClientAdapter::didReceiveResponse(
unsigned long,
const ResourceResponse& response,
std::unique_ptr<WebDataConsumerHandle> handle) {
- ASSERT_UNUSED(handle, !handle);
+ DCHECK(!handle);
if (!m_client)
return;
@@ -290,12 +290,10 @@ void AssociatedURLLoader::ClientAdapter::enableErrorNotifications() {
}
void AssociatedURLLoader::ClientAdapter::notifyError(TimerBase* timer) {
- ASSERT_UNUSED(timer, timer == &m_errorTimer);
+ DCHECK_EQ(timer, &m_errorTimer);
- if (!m_client)
- return;
-
- releaseClient()->didFail(m_loader, m_error);
+ if (m_client)
+ releaseClient()->didFail(m_loader, m_error);
// |this| may be dead here.
}

Powered by Google App Engine
This is Rietveld 408576698