Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Unified Diff: third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp

Issue 2394683005: Remove ASSERT_UNUSED (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp
diff --git a/third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp b/third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp
index 5a8f5a365925cc8bf4d797c34f1c1b27c969dbde..a5bdac5df0c598762d47bea731b80907a78b347d 100644
--- a/third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp
+++ b/third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp
@@ -159,7 +159,7 @@ static UText* textClone(UText* destination,
const UText* source,
UBool deep,
UErrorCode* status) {
- ASSERT_UNUSED(deep, !deep);
+ DCHECK(!deep);
if (U_FAILURE(*status))
return 0;
int32_t extraSize = source->extraSize;
@@ -265,10 +265,8 @@ static void textLatin1MoveInPriorContext(UText* text,
UBool forward) {
ASSERT(text->chunkContents == text->q);
ASSERT(forward ? nativeIndex < text->b : nativeIndex <= text->b);
- ASSERT_UNUSED(nativeLength, forward ? nativeIndex < nativeLength
- : nativeIndex <= nativeLength);
- ASSERT_UNUSED(forward, forward ? nativeIndex < nativeLength
- : nativeIndex <= nativeLength);
+ DCHECK(forward ? nativeIndex < nativeLength : nativeIndex <= nativeLength);
+ DCHECK(forward ? nativeIndex < nativeLength : nativeIndex <= nativeLength);
text->chunkNativeStart = 0;
text->chunkNativeLimit = text->b;
text->chunkLength = text->b;
@@ -421,10 +419,8 @@ static void textUTF16MoveInPrimaryContext(UText* text,
int64_t nativeLength,
UBool forward) {
ASSERT(text->chunkContents == text->p);
- ASSERT_UNUSED(forward,
- forward ? nativeIndex >= text->b : nativeIndex > text->b);
- ASSERT_UNUSED(forward, forward ? nativeIndex < nativeLength
- : nativeIndex <= nativeLength);
+ DCHECK(forward ? nativeIndex >= text->b : nativeIndex > text->b);
+ DCHECK(forward ? nativeIndex < nativeLength : nativeIndex <= nativeLength);
text->chunkNativeStart = text->b;
text->chunkNativeLimit = nativeLength;
int64_t length = text->chunkNativeLimit - text->chunkNativeStart;
@@ -460,10 +456,8 @@ static void textUTF16MoveInPriorContext(UText* text,
UBool forward) {
ASSERT(text->chunkContents == text->q);
ASSERT(forward ? nativeIndex < text->b : nativeIndex <= text->b);
- ASSERT_UNUSED(nativeLength, forward ? nativeIndex < nativeLength
- : nativeIndex <= nativeLength);
- ASSERT_UNUSED(forward, forward ? nativeIndex < nativeLength
- : nativeIndex <= nativeLength);
+ DCHECK(forward ? nativeIndex < nativeLength : nativeIndex <= nativeLength);
+ DCHECK(forward ? nativeIndex < nativeLength : nativeIndex <= nativeLength);
text->chunkNativeStart = 0;
text->chunkNativeLimit = text->b;
text->chunkLength = text->b;

Powered by Google App Engine
This is Rietveld 408576698