Remove ASSERT_UNUSED

third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl

 {% extends 'interface_base.cpp.tmpl' %}
 
 {% set has_prepare_prototype_and_interface_object =
     unscopables or has_conditional_attributes_on_prototype or
     methods | conditionally_exposed(is_partial) %}
 {% set prepare_prototype_and_interface_object_func =
     '%s::preparePrototypeAndInterfaceObject' % v8_class
     if has_prepare_prototype_and_interface_object
     else 'nullptr' %}
 
@@ skipping 823 matching lines @@
         RELEASE_ASSERT(wrapperTypeInfo->ginEmbedder == gin::kEmbedderBlink);
         return toScriptWrappable(object)->toImpl<{{cpp_class}}>();
     }
 
     // Transfer the ownership of the allocated memory to an {{interface_name}} without
     // copying.
     v8::{{interface_name}}::Contents v8Contents = v8buffer->Externalize();
     WTF::ArrayBufferContents contents(v8Contents.Data(), v8Contents.ByteLength(), WTF::ArrayBufferContents::{% if interface_name == 'ArrayBuffer' %}Not{% endif %}Shared);
     {{cpp_class}}* buffer = {{cpp_class}}::create(contents);
     v8::Local<v8::Object> associatedWrapper = buffer->associateWithWrapper(v8::Isolate::GetCurrent(), buffer->wrapperTypeInfo(), object);
-    ASSERT_UNUSED(associatedWrapper, associatedWrapper == object);
+    DCHECK(associatedWrapper == object);

[Yuta Kitamura, 2016/10/06 10:50:04]

Does DCHECK_EQ cause some problem?

[tkent, 2016/10/06 14:07:19]

DCHECK_EQ requires operator<< for v8::Local<>, and operator== for v8::Local<>
and operator== for *v8::Local<> are not same.

 
     return buffer;
 }
 
 {% elif interface_name == 'ArrayBufferView' %}
 {{cpp_class}}* V8ArrayBufferView::toImpl(v8::Local<v8::Object> object)
 {
     ASSERT(object->IsArrayBufferView());
     ScriptWrappable* scriptWrappable = toScriptWrappable(object);
     if (scriptWrappable)
@@ skipping 36 matching lines @@
     v8::Local<v8::Object> arrayBuffer = v8View->Buffer();
     {{cpp_class}}* typedArray = nullptr;
     if (arrayBuffer->IsArrayBuffer()) {
         typedArray = {{cpp_class}}::create(V8ArrayBuffer::toImpl(arrayBuffer), v8View->ByteOffset(), v8View->{% if interface_name == 'DataView' %}Byte{% endif %}Length());
     } else if (arrayBuffer->IsSharedArrayBuffer()) {
         typedArray = {{cpp_class}}::create(V8SharedArrayBuffer::toImpl(arrayBuffer), v8View->ByteOffset(), v8View->{% if interface_name == 'DataView' %}Byte{% endif %}Length());
     } else {
         ASSERT_NOT_REACHED();
     }
     v8::Local<v8::Object> associatedWrapper = typedArray->associateWithWrapper(v8::Isolate::GetCurrent(), typedArray->wrapperTypeInfo(), object);
-    ASSERT_UNUSED(associatedWrapper, associatedWrapper == object);
+    DCHECK(associatedWrapper == object);
 
     return typedArray->toImpl<{{cpp_class}}>();
 }
 
 {% endif %}
 {% endblock %}
 
 
 {##############################################################################}
 {% block to_impl_with_type_check %}
@@ skipping 80 matching lines @@
 
 {% for method in methods if method.overloads and method.overloads.has_partial_overloads %}
 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInterface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&))
 {
     {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method;
 }
 
 {% endfor %}
 {% endif %}
 {% endblock %}