third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp - Issue 2394683005: Remove ASSERT_UNUSED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

Issue 2394683005: Remove ASSERT_UNUSED (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

index 41779bb3e1c67d2d180272b2c60aaf6355095888..969acebd627b9db14e3443805e614b855eb151b6 100644

--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

@@ -328,7 +328,7 @@ void CSSPrimitiveValue::accumulateLengthArray(CSSLengthArray& lengthArray,

LengthUnitType lengthType;

bool conversionSuccess = unitTypeToLengthUnitType(type(), lengthType);

- ASSERT_UNUSED(conversionSuccess, conversionSuccess);

+ DCHECK(conversionSuccess);

lengthArray.values[lengthType] +=

m_value.num * conversionToCanonicalUnitsScaleFactor(type()) * multiplier;

lengthArray.typeFlags.set(lengthType);