third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp - Issue 2394683005: Remove ASSERT_UNUSED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp

Issue 2394683005: Remove ASSERT_UNUSED (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl ('K') | « third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp ('k') | third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutTableCol.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp

diff --git a/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp b/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp

index eb932a62d717c7be58073602315182b11bf9a3bc..73404bec56e04cc7316619bf03240e7864d90514 100644

--- a/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp

+++ b/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp

@@ -66,7 +66,7 @@ EphemeralRangeTemplate<Strategy> CharacterIteratorAlgorithm<Strategy>::range()

PositionTemplate<Strategy> endPosition =

range.endPosition().parentAnchoredEquivalent();

Node* node = startPosition.computeContainerNode();

- ASSERT_UNUSED(endPosition, node == endPosition.computeContainerNode());

+ DCHECK_EQ(node, endPosition.computeContainerNode());

int offset = startPosition.offsetInContainerNode() + m_runOffset;

return EphemeralRangeTemplate<Strategy>(

PositionTemplate<Strategy>(node, offset),