Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableCol.cpp

Issue 2394683005: Remove ASSERT_UNUSED (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTableCol.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableCol.cpp b/third_party/WebKit/Source/core/layout/LayoutTableCol.cpp
index 3b89415230e4a45f28a43288871438bef185e919..127fbb0c1a667c8f662e129046124b104932c426 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableCol.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTableCol.cpp
@@ -178,17 +178,20 @@ const BorderValue& LayoutTableCol::borderAdjoiningCellEndBorder(
const BorderValue& LayoutTableCol::borderAdjoiningCellBefore(
const LayoutTableCell* cell) const {
- ASSERT_UNUSED(cell, table()->colElementAtAbsoluteColumn(
- cell->absoluteColumnIndex() + cell->colSpan())
- .innermostColOrColGroup() == this);
+ DCHECK_EQ(table()
Yuta Kitamura 2016/10/06 10:50:04 nit: Maybe you want to wrap after "DCHECK_EQ(" to
tkent 2016/10/06 14:07:19 Even if we manually wrap after DCHECK_EQ(, |git cl
+ ->colElementAtAbsoluteColumn(cell->absoluteColumnIndex() +
+ cell->colSpan())
+ .innermostColOrColGroup(),
+ this);
return style()->borderStart();
}
const BorderValue& LayoutTableCol::borderAdjoiningCellAfter(
const LayoutTableCell* cell) const {
- ASSERT_UNUSED(
- cell, table()->colElementAtAbsoluteColumn(cell->absoluteColumnIndex() - 1)
- .innermostColOrColGroup() == this);
+ DCHECK_EQ(table()
Yuta Kitamura 2016/10/06 10:50:04 Ditto.
+ ->colElementAtAbsoluteColumn(cell->absoluteColumnIndex() - 1)
+ .innermostColOrColGroup(),
+ this);
return style()->borderEnd();
}

Powered by Google App Engine
This is Rietveld 408576698