Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: third_party/WebKit/Source/wtf/ThreadingWin.cpp

Issue 2394683005: Remove ASSERT_UNUSED (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/wtf/ThreadingWin.cpp
diff --git a/third_party/WebKit/Source/wtf/ThreadingWin.cpp b/third_party/WebKit/Source/wtf/ThreadingWin.cpp
index 00c63a40759bbd160690ff8bd4e6273d8e181cbe..8df017dd2a54e074ac5d9485d09b0fbed2de1d45 100644
--- a/third_party/WebKit/Source/wtf/ThreadingWin.cpp
+++ b/third_party/WebKit/Source/wtf/ThreadingWin.cpp
@@ -218,10 +218,10 @@ bool PlatformCondition::timedWait(PlatformMutex& mutex,
DWORD durationMilliseconds) {
// Enter the wait state.
DWORD res = WaitForSingleObject(m_blockLock, INFINITE);
- ASSERT_UNUSED(res, res == WAIT_OBJECT_0);
+ DCHECK_EQ(res, WAIT_OBJECT_0);
++m_waitersBlocked;
res = ReleaseSemaphore(m_blockLock, 1, 0);
- ASSERT_UNUSED(res, res);
+ DCHECK(res);
--mutex.m_recursionCount;
LeaveCriticalSection(&mutex.m_internalMutex);
@@ -231,7 +231,7 @@ bool PlatformCondition::timedWait(PlatformMutex& mutex,
(WaitForSingleObject(m_blockQueue, durationMilliseconds) == WAIT_TIMEOUT);
res = WaitForSingleObject(m_unblockLock, INFINITE);
- ASSERT_UNUSED(res, res == WAIT_OBJECT_0);
+ DCHECK_EQ(res, WAIT_OBJECT_0);
int signalsLeft = m_waitersToUnblock;
@@ -242,19 +242,19 @@ bool PlatformCondition::timedWait(PlatformMutex& mutex,
// occured, normalize the m_waitersGone count this may occur if many
// calls to wait with a timeout are made and no call to notify_* is made
res = WaitForSingleObject(m_blockLock, INFINITE);
- ASSERT_UNUSED(res, res == WAIT_OBJECT_0);
+ DCHECK_EQ(res, WAIT_OBJECT_0);
m_waitersBlocked -= m_waitersGone;
res = ReleaseSemaphore(m_blockLock, 1, 0);
- ASSERT_UNUSED(res, res);
+ DCHECK(res);
m_waitersGone = 0;
}
res = ReleaseMutex(m_unblockLock);
- ASSERT_UNUSED(res, res);
+ DCHECK(res);
if (signalsLeft == 1) {
res = ReleaseSemaphore(m_blockLock, 1, 0); // Open the gate.
- ASSERT_UNUSED(res, res);
+ DCHECK(res);
}
EnterCriticalSection(&mutex.m_internalMutex);
@@ -267,12 +267,12 @@ void PlatformCondition::signal(bool unblockAll) {
unsigned signalsToIssue = 0;
DWORD res = WaitForSingleObject(m_unblockLock, INFINITE);
- ASSERT_UNUSED(res, res == WAIT_OBJECT_0);
+ DCHECK_EQ(res, WAIT_OBJECT_0);
if (m_waitersToUnblock) { // the gate is already closed
if (!m_waitersBlocked) { // no-op
res = ReleaseMutex(m_unblockLock);
- ASSERT_UNUSED(res, res);
+ DCHECK(res);
return;
}
@@ -287,7 +287,7 @@ void PlatformCondition::signal(bool unblockAll) {
}
} else if (m_waitersBlocked > m_waitersGone) {
res = WaitForSingleObject(m_blockLock, INFINITE); // Close the gate.
- ASSERT_UNUSED(res, res == WAIT_OBJECT_0);
+ DCHECK_EQ(res, WAIT_OBJECT_0);
if (m_waitersGone != 0) {
m_waitersBlocked -= m_waitersGone;
m_waitersGone = 0;
@@ -303,16 +303,16 @@ void PlatformCondition::signal(bool unblockAll) {
}
} else { // No-op.
res = ReleaseMutex(m_unblockLock);
- ASSERT_UNUSED(res, res);
+ DCHECK(res);
return;
}
res = ReleaseMutex(m_unblockLock);
- ASSERT_UNUSED(res, res);
+ DCHECK(res);
if (signalsToIssue) {
res = ReleaseSemaphore(m_blockQueue, signalsToIssue, 0);
- ASSERT_UNUSED(res, res);
+ DCHECK(res);
}
}

Powered by Google App Engine
This is Rietveld 408576698