Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTableCol.cpp

Issue 2394683005: Remove ASSERT_UNUSED (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2009 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2009 Apple Inc. All rights reserved.
8 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 8 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 return style()->borderStart(); 171 return style()->borderStart();
172 } 172 }
173 173
174 const BorderValue& LayoutTableCol::borderAdjoiningCellEndBorder( 174 const BorderValue& LayoutTableCol::borderAdjoiningCellEndBorder(
175 const LayoutTableCell*) const { 175 const LayoutTableCell*) const {
176 return style()->borderEnd(); 176 return style()->borderEnd();
177 } 177 }
178 178
179 const BorderValue& LayoutTableCol::borderAdjoiningCellBefore( 179 const BorderValue& LayoutTableCol::borderAdjoiningCellBefore(
180 const LayoutTableCell* cell) const { 180 const LayoutTableCell* cell) const {
181 ASSERT_UNUSED(cell, table()->colElementAtAbsoluteColumn( 181 DCHECK_EQ(table()
Yuta Kitamura 2016/10/06 10:50:04 nit: Maybe you want to wrap after "DCHECK_EQ(" to
tkent 2016/10/06 14:07:19 Even if we manually wrap after DCHECK_EQ(, |git cl
182 cell->absoluteColumnIndex() + cell->colSpan()) 182 ->colElementAtAbsoluteColumn(cell->absoluteColumnIndex() +
183 .innermostColOrColGroup() == this); 183 cell->colSpan())
184 .innermostColOrColGroup(),
185 this);
184 return style()->borderStart(); 186 return style()->borderStart();
185 } 187 }
186 188
187 const BorderValue& LayoutTableCol::borderAdjoiningCellAfter( 189 const BorderValue& LayoutTableCol::borderAdjoiningCellAfter(
188 const LayoutTableCell* cell) const { 190 const LayoutTableCell* cell) const {
189 ASSERT_UNUSED( 191 DCHECK_EQ(table()
Yuta Kitamura 2016/10/06 10:50:04 Ditto.
190 cell, table()->colElementAtAbsoluteColumn(cell->absoluteColumnIndex() - 1) 192 ->colElementAtAbsoluteColumn(cell->absoluteColumnIndex() - 1)
191 .innermostColOrColGroup() == this); 193 .innermostColOrColGroup(),
194 this);
192 return style()->borderEnd(); 195 return style()->borderEnd();
193 } 196 }
194 197
195 } // namespace blink 198 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698