Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: third_party/WebKit/Source/wtf/Assertions.h

Issue 2394683005: Remove ASSERT_UNUSED (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/wtf/Assertions.h
diff --git a/third_party/WebKit/Source/wtf/Assertions.h b/third_party/WebKit/Source/wtf/Assertions.h
index feb59f174a226e86c099527400dda32a15fe15e9..ea39eb04410571c641950a84d519baacf591e765 100644
--- a/third_party/WebKit/Source/wtf/Assertions.h
+++ b/third_party/WebKit/Source/wtf/Assertions.h
@@ -183,13 +183,12 @@ class WTF_EXPORT ScopedLogger {
#define NO_RETURN_DUE_TO_CRASH
#endif
-// ASSERT, ASSERT_NOT_REACHED, ASSERT_UNUSED
+// ASSERT and ASSERT_NOT_REACHED
// These macros are compiled out of release builds.
// Expressions inside them are evaluated in debug builds only.
// They are deprecated. We should use:
// - DCHECK() for ASSERT()
// - NOTREACHED() for ASSERT_NOT_REACHED()
-// - DCHECK() for ASSERT_UNUSED().
#if OS(WIN)
// FIXME: Change to use something other than ASSERT to avoid this conflict with
// the underlying platform.
@@ -214,8 +213,6 @@ class WTF_EXPORT ScopedLogger {
CRASH(); \
} while (0)
-#define ASSERT_UNUSED(variable, assertion) ASSERT(assertion)
-
#define NO_RETURN_DUE_TO_ASSERT NO_RETURN_DUE_TO_CRASH
#else
@@ -224,8 +221,6 @@ class WTF_EXPORT ScopedLogger {
#define ASSERT_NOT_REACHED() ((void)0)
#define NO_RETURN_DUE_TO_ASSERT
-#define ASSERT_UNUSED(variable, assertion) ((void)variable)
-
#endif
// ASSERT_WITH_SECURITY_IMPLICATION

Powered by Google App Engine
This is Rietveld 408576698