Update OnCommit to return ObservePolicy.

Update OnCommit to return ObservePolicy.

BUG=647764
Committed: https://crrev.com/fc9831da34aaf34e58cc1744dd87cc24d43d2f1b
Cr-Commit-Position: refs/heads/master@{#421299}

[Bryan McQuade, 2016-09-27 13:53:17]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 13:53:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 14:20:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 14:20:17]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Bryan McQuade, 2016-09-27 14:36:58]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 14:37:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 15:25:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 15:25:46]

Dry run: This issue passed the CQ dry run.

[Bryan McQuade, 2016-09-27 16:18:25]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 16:18:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2016-09-27 16:19:15]

bmcquade@chromium.org changed reviewers:
+ csharrison@chromium.org

[Bryan McQuade, 2016-09-27 16:19:35]

Here's a first pass at updating OnCommit to return ObservePolicy. PTAL and see
what you think.

[Charlie Harrison, 2016-09-27 16:32:48]

Looks great, can you update the BUG= to point to the chrome:// bug?

I'll have an OnStart patch up shortly

https://codereview.chromium.org/2372573005/diff/40001/chrome/browser/page_loa...
File chrome/browser/page_load_metrics/metrics_web_contents_observer.cc (right):

https://codereview.chromium.org/2372573005/diff/40001/chrome/browser/page_loa...
chrome/browser/page_load_metrics/metrics_web_contents_observer.cc:446: for (auto
it = observers_.begin(); it != observers_.end();) {
Refactor this to a common method?

[commit-bot: I haz the power, 2016-09-27 17:05:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 17:05:06]

Dry run: This issue passed the CQ dry run.

[Bryan McQuade, 2016-09-27 17:55:47]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[Bryan McQuade, 2016-09-27 17:56:09]

Description was changed from

==========
Update OnCommit to return ObservePolicy.

BUG=
==========

to

==========
Update OnCommit to return ObservePolicy.

BUG=647764
==========

[commit-bot: I haz the power, 2016-09-27 17:56:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2016-09-27 18:00:11]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[Bryan McQuade, 2016-09-27 18:00:15]

Thanks! I factored the iteration into a helper macro, as we discussed. PTAL.

https://codereview.chromium.org/2372573005/diff/40001/chrome/browser/page_loa...
File chrome/browser/page_load_metrics/metrics_web_contents_observer.cc (right):

https://codereview.chromium.org/2372573005/diff/40001/chrome/browser/page_loa...
chrome/browser/page_load_metrics/metrics_web_contents_observer.cc:446: for (auto
it = observers_.begin(); it != observers_.end();) {
On 2016/09/27 at 16:32:48, Charlie Harrison wrote:
> Refactor this to a common method?

Sure, I factored it into a macro, per our conversation.

[commit-bot: I haz the power, 2016-09-27 18:00:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2016-09-27 18:20:05]

Woohoo! LGTM

[Bryan McQuade, 2016-09-27 18:26:00]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 18:26:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 19:17:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 19:17:07]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2016-09-27 19:30:36]

LGTM. I'll have a followup CL for cleaning up the DRP observer (specifically
data_->used_data_reduction_proxy() is checked everywhere, so I need to move that
to OnCommit and remove it elsewhere) and shuttting down
FlushMetricsOnAppEnterBackground.

Thanks for this!

[Bryan McQuade, 2016-09-27 19:31:40]

The CQ bit was checked by bmcquade@chromium.org

[Bryan McQuade, 2016-09-27 19:31:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
csharrison@chromium.org
Link to the patchset: https://codereview.chromium.org/2372573005/#ps100001
(title: "restore missing private:")

[commit-bot: I haz the power, 2016-09-27 19:32:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 19:40:02]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-27 19:42:28]

Description was changed from

==========
Update OnCommit to return ObservePolicy.

BUG=647764
==========

to

==========
Update OnCommit to return ObservePolicy.

BUG=647764

Committed: https://crrev.com/fc9831da34aaf34e58cc1744dd87cc24d43d2f1b
Cr-Commit-Position: refs/heads/master@{#421299}
==========

[commit-bot: I haz the power, 2016-09-27 19:42:30]

Patchset 6 (id:??) landed as
https://crrev.com/fc9831da34aaf34e58cc1744dd87cc24d43d2f1b
Cr-Commit-Position: refs/heads/master@{#421299}