Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1191)

Unified Diff: chrome/browser/page_load_metrics/observers/google_captcha_observer.cc

Issue 2372573005: Update OnCommit to return ObservePolicy. (Closed)
Patch Set: restore missing private: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/google_captcha_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/google_captcha_observer.cc b/chrome/browser/page_load_metrics/observers/google_captcha_observer.cc
index b1bdf1ef6891149d6059cee007f87893017b596a..afdad0f7f0390516589e6bba2e3f137e9f7691e6 100644
--- a/chrome/browser/page_load_metrics/observers/google_captcha_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/google_captcha_observer.cc
@@ -44,12 +44,13 @@ bool IsGoogleCaptcha(const GURL& url) {
GoogleCaptchaObserver::GoogleCaptchaObserver() : saw_solution_(false) {}
-void GoogleCaptchaObserver::OnCommit(
- content::NavigationHandle* navigation_handle) {
+page_load_metrics::PageLoadMetricsObserver::ObservePolicy
+GoogleCaptchaObserver::OnCommit(content::NavigationHandle* navigation_handle) {
if (!navigation_handle->IsSamePage()
&& IsGoogleCaptcha(navigation_handle->GetURL())) {
RecordGoogleCaptchaEvent(GOOGLE_CAPTCHA_SHOWN);
}
+ return CONTINUE_OBSERVING;
}
void GoogleCaptchaObserver::OnRedirect(

Powered by Google App Engine
This is Rietveld 408576698