Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

Issue 2372573005: Update OnCommit to return ObservePolicy. (Closed)
Patch Set: restore missing private: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
index 2e15f0603ce12fa0dfbe68dbb41eb91432ed465c..f7c44b2e982748fc9d2ca398e748c3351ab788bc 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
@@ -214,7 +214,8 @@ CorePageLoadMetricsObserver::CorePageLoadMetricsObserver()
CorePageLoadMetricsObserver::~CorePageLoadMetricsObserver() {}
-void CorePageLoadMetricsObserver::OnCommit(
+page_load_metrics::PageLoadMetricsObserver::ObservePolicy
+CorePageLoadMetricsObserver::OnCommit(
content::NavigationHandle* navigation_handle) {
transition_ = navigation_handle->GetPageTransition();
initiated_by_user_gesture_ = navigation_handle->HasUserGesture();
@@ -225,6 +226,7 @@ void CorePageLoadMetricsObserver::OnCommit(
was_no_store_main_resource_ =
headers->HasHeaderValue("cache-control", "no-store");
}
+ return CONTINUE_OBSERVING;
}
void CorePageLoadMetricsObserver::OnDomContentLoadedEventStart(

Powered by Google App Engine
This is Rietveld 408576698