Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h

Issue 2372573005: Update OnCommit to return ObservePolicy. (Closed)
Patch Set: restore missing private: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_ OBSERVER_H_ 5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_ OBSERVER_H_
6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_ OBSERVER_H_ 6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_ OBSERVER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 44
45 // Observer responsible for recording core page load metrics releveant to 45 // Observer responsible for recording core page load metrics releveant to
46 // DataReductionProxy. 46 // DataReductionProxy.
47 class DataReductionProxyMetricsObserver 47 class DataReductionProxyMetricsObserver
48 : public page_load_metrics::PageLoadMetricsObserver { 48 : public page_load_metrics::PageLoadMetricsObserver {
49 public: 49 public:
50 DataReductionProxyMetricsObserver(); 50 DataReductionProxyMetricsObserver();
51 ~DataReductionProxyMetricsObserver() override; 51 ~DataReductionProxyMetricsObserver() override;
52 52
53 // page_load_metrics::PageLoadMetricsObserver: 53 // page_load_metrics::PageLoadMetricsObserver:
54 void OnCommit(content::NavigationHandle* navigation_handle) override; 54 ObservePolicy OnCommit(content::NavigationHandle* navigation_handle) override;
55 void OnComplete(const page_load_metrics::PageLoadTiming& timing, 55 void OnComplete(const page_load_metrics::PageLoadTiming& timing,
56 const page_load_metrics::PageLoadExtraInfo& info) override; 56 const page_load_metrics::PageLoadExtraInfo& info) override;
57 void OnDomContentLoadedEventStart( 57 void OnDomContentLoadedEventStart(
58 const page_load_metrics::PageLoadTiming& timing, 58 const page_load_metrics::PageLoadTiming& timing,
59 const page_load_metrics::PageLoadExtraInfo& info) override; 59 const page_load_metrics::PageLoadExtraInfo& info) override;
60 void OnLoadEventStart( 60 void OnLoadEventStart(
61 const page_load_metrics::PageLoadTiming& timing, 61 const page_load_metrics::PageLoadTiming& timing,
62 const page_load_metrics::PageLoadExtraInfo& info) override; 62 const page_load_metrics::PageLoadExtraInfo& info) override;
63 void OnFirstLayout(const page_load_metrics::PageLoadTiming& timing, 63 void OnFirstLayout(const page_load_metrics::PageLoadTiming& timing,
64 const page_load_metrics::PageLoadExtraInfo& info) override; 64 const page_load_metrics::PageLoadExtraInfo& info) override;
(...skipping 22 matching lines...) Expand all
87 87
88 // The browser context this navigation is operating in. 88 // The browser context this navigation is operating in.
89 content::BrowserContext* browser_context_; 89 content::BrowserContext* browser_context_;
90 90
91 DISALLOW_COPY_AND_ASSIGN(DataReductionProxyMetricsObserver); 91 DISALLOW_COPY_AND_ASSIGN(DataReductionProxyMetricsObserver);
92 }; 92 };
93 93
94 } // namespace data_reduction_proxy 94 } // namespace data_reduction_proxy
95 95
96 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRI CS_OBSERVER_H_ 96 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRI CS_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698