Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Side by Side Diff: chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h

Issue 2372573005: Update OnCommit to return ObservePolicy. (Closed)
Patch Set: restore missing private: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_STALE_WHILE_REVALIDATE_METRIC S_OBSERVER_H_ 5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_STALE_WHILE_REVALIDATE_METRIC S_OBSERVER_H_
6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_STALE_WHILE_REVALIDATE_METRIC S_OBSERVER_H_ 6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_STALE_WHILE_REVALIDATE_METRIC S_OBSERVER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "chrome/browser/page_load_metrics/page_load_metrics_observer.h" 9 #include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
10 10
11 namespace chrome { 11 namespace chrome {
12 12
13 class StaleWhileRevalidateMetricsObserver 13 class StaleWhileRevalidateMetricsObserver
14 : public page_load_metrics::PageLoadMetricsObserver { 14 : public page_load_metrics::PageLoadMetricsObserver {
15 public: 15 public:
16 StaleWhileRevalidateMetricsObserver(); 16 StaleWhileRevalidateMetricsObserver();
17 // page_load_metrics::PageLoadMetricsObserver implementation: 17 // page_load_metrics::PageLoadMetricsObserver implementation:
18 void OnCommit(content::NavigationHandle* navigation_handle) override; 18 ObservePolicy OnCommit(content::NavigationHandle* navigation_handle) override;
19 void OnComplete( 19 void OnComplete(
20 const page_load_metrics::PageLoadTiming& timing, 20 const page_load_metrics::PageLoadTiming& timing,
21 const page_load_metrics::PageLoadExtraInfo& extra_info) override; 21 const page_load_metrics::PageLoadExtraInfo& extra_info) override;
22 22
23 private: 23 private:
24 // True if the committed URL is one of the domains of interest to the
25 // stale-while-revalidate experiment.
26 bool is_interesting_domain_;
27
28 DISALLOW_COPY_AND_ASSIGN(StaleWhileRevalidateMetricsObserver); 24 DISALLOW_COPY_AND_ASSIGN(StaleWhileRevalidateMetricsObserver);
29 }; 25 };
30 26
31 } // namespace chrome 27 } // namespace chrome
32 28
33 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_STALE_WHILE_REVALIDATE_MET RICS_OBSERVER_H_ 29 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_STALE_WHILE_REVALIDATE_MET RICS_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698