Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1741)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.h

Issue 2372573005: Update OnCommit to return ObservePolicy. (Closed)
Patch Set: restore missing private: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.h b/chrome/browser/page_load_metrics/page_load_metrics_observer.h
index e33bce41f7a98946390d61cb8615ece2acad1984..e60224022ff447bb3ef0663ca1fc912163b4c09b 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.h
@@ -164,7 +164,9 @@ class PageLoadMetricsObserver {
// the navigation, but will be destroyed soon after this call. Don't hold a
// reference to it.
// Note that this does not get called for same page navigations.
- virtual void OnCommit(content::NavigationHandle* navigation_handle) {}
+ // Observers that return STOP_OBSERVING will not receive any additional
+ // callbacks, and will be deleted after invocation of this method returns.
+ virtual ObservePolicy OnCommit(content::NavigationHandle* navigation_handle);
// OnHidden is triggered when a page leaves the foreground. It does not fire
// when a foreground page is permanently closed; for that, listen to

Powered by Google App Engine
This is Rietveld 408576698