Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4920)

Unified Diff: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc

Issue 2372573005: Update OnCommit to return ObservePolicy. (Closed)
Patch Set: restore missing private: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
index 8b460cfb68e4f8f21181cdab31716b01b1d71204..e0a445497921a99852fed6905e4c743c7f78d0f7 100644
--- a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
@@ -91,7 +91,8 @@ DataReductionProxyMetricsObserver::DataReductionProxyMetricsObserver()
DataReductionProxyMetricsObserver::~DataReductionProxyMetricsObserver() {}
// Check if the NavigationData indicates anything about the DataReductionProxy.
-void DataReductionProxyMetricsObserver::OnCommit(
+page_load_metrics::PageLoadMetricsObserver::ObservePolicy
+DataReductionProxyMetricsObserver::OnCommit(
content::NavigationHandle* navigation_handle) {
// This BrowserContext is valid for the lifetime of
// DataReductionProxyMetricsObserver. BrowserContext is always valid and
@@ -110,15 +111,16 @@ void DataReductionProxyMetricsObserver::OnCommit(
static_cast<ChromeNavigationData*>(
navigation_handle->GetNavigationData());
if (!chrome_navigation_data)
- return;
+ return STOP_OBSERVING;
data_reduction_proxy::DataReductionProxyData* data =
chrome_navigation_data->GetDataReductionProxyData();
if (!data)
- return;
+ return STOP_OBSERVING;
data_ = data->DeepCopy();
// DataReductionProxy page loads should only occur on HTTP navigations.
DCHECK(!data_->used_data_reduction_proxy() ||
!navigation_handle->GetURL().SchemeIsCryptographic());
+ return CONTINUE_OBSERVING;
}
void DataReductionProxyMetricsObserver::OnComplete(

Powered by Google App Engine
This is Rietveld 408576698