Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2701)

Unified Diff: chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc

Issue 2372573005: Update OnCommit to return ObservePolicy. (Closed)
Patch Set: restore missing private: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc
index 3299d3a3f96deb8e2fbb6259ec7c9bbe87b25bda..88012dae64b7b329227e807914cdd2c8314a7c70 100644
--- a/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc
@@ -11,13 +11,15 @@
namespace chrome {
-StaleWhileRevalidateMetricsObserver::StaleWhileRevalidateMetricsObserver()
- : is_interesting_domain_(false) {}
+StaleWhileRevalidateMetricsObserver::StaleWhileRevalidateMetricsObserver() {}
-void StaleWhileRevalidateMetricsObserver::OnCommit(
+page_load_metrics::PageLoadMetricsObserver::ObservePolicy
+StaleWhileRevalidateMetricsObserver::OnCommit(
content::NavigationHandle* navigation_handle) {
- is_interesting_domain_ = net::IsHostInStaleWhileRevalidateExperimentDomain(
- navigation_handle->GetURL().host());
+ return net::IsHostInStaleWhileRevalidateExperimentDomain(
+ navigation_handle->GetURL().host())
+ ? CONTINUE_OBSERVING
+ : STOP_OBSERVING;
}
void StaleWhileRevalidateMetricsObserver::OnComplete(
@@ -25,9 +27,6 @@ void StaleWhileRevalidateMetricsObserver::OnComplete(
const page_load_metrics::PageLoadExtraInfo& extra_info) {
using page_load_metrics::WasStartedInForegroundOptionalEventInForeground;
- if (!is_interesting_domain_)
- return;
-
if (WasStartedInForegroundOptionalEventInForeground(timing.load_event_start,
extra_info)) {
PAGE_LOAD_HISTOGRAM(

Powered by Google App Engine
This is Rietveld 408576698