Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc

Issue 2372573005: Update OnCommit to return ObservePolicy. (Closed)
Patch Set: restore missing private: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
index a493154bc861225c79ec650ff9af20d4b3847ebf..df210c62931ad811edced4f092811d4dd6f62cf2 100644
--- a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
@@ -100,12 +100,13 @@ class TestDataReductionProxyMetricsObserver
~TestDataReductionProxyMetricsObserver() override {}
// page_load_metrics::PageLoadMetricsObserver implementation:
- void OnCommit(content::NavigationHandle* navigation_handle) override {
+ ObservePolicy OnCommit(
+ content::NavigationHandle* navigation_handle) override {
DataReductionProxyData* data =
DataForNavigationHandle(web_contents_, navigation_handle);
data->set_used_data_reduction_proxy(data_reduction_proxy_used_);
data->set_lofi_requested(lofi_used_);
- DataReductionProxyMetricsObserver::OnCommit(navigation_handle);
+ return DataReductionProxyMetricsObserver::OnCommit(navigation_handle);
}
DataReductionProxyPingbackClient* GetPingbackClient() const override {

Powered by Google App Engine
This is Rietveld 408576698