chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc - Issue 2372573005: Update OnCommit to return ObservePolicy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc

Issue 2372573005: Update OnCommit to return ObservePolicy. (Closed)

Patch Set: restore missing private: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.h ('k') | chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc

index daf10edac20386e541a0af650e24ab80c726424b..6baaecd2057f92a4c1eef85268b2a85c6e8cdfb6 100644

--- a/chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc

@@ -32,13 +32,15 @@ NoStatePrefetchPageLoadMetricsObserver::NoStatePrefetchPageLoadMetricsObserver(

NoStatePrefetchPageLoadMetricsObserver::

~NoStatePrefetchPageLoadMetricsObserver() {}

-void NoStatePrefetchPageLoadMetricsObserver::OnCommit(

+page_load_metrics::PageLoadMetricsObserver::ObservePolicy

+NoStatePrefetchPageLoadMetricsObserver::OnCommit(

content::NavigationHandle* navigation_handle) {

const net::HttpResponseHeaders* response_headers =

navigation_handle->GetResponseHeaders();

is_no_store_ = response_headers &&

response_headers->HasHeaderValue("cache-control", "no-store");

+ return CONTINUE_OBSERVING;

}

void NoStatePrefetchPageLoadMetricsObserver::OnFirstContentfulPaint(