Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Unified Diff: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc

Issue 2372573005: Update OnCommit to return ObservePolicy. (Closed)
Patch Set: restore missing private: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
index 1d897694888789eeb8335ca0e866d85216c75fa9..802c5fdae543d3cd54b5e57fa4c83f92bc564449 100644
--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
@@ -412,7 +412,8 @@ void FromGWSPageLoadMetricsObserver::OnStart(
logger_.SetProvisionalUrl(navigation_handle->GetURL());
}
-void FromGWSPageLoadMetricsObserver::OnCommit(
+page_load_metrics::PageLoadMetricsObserver::ObservePolicy
+FromGWSPageLoadMetricsObserver::OnCommit(
content::NavigationHandle* navigation_handle) {
// We'd like to also check navigation_handle->HasUserGesture() here, however
// this signal is not carried forward for navigations that open links in new
@@ -427,6 +428,7 @@ void FromGWSPageLoadMetricsObserver::OnCommit(
navigation_handle->GetPageTransition()));
logger_.SetNavigationStart(navigation_handle->NavigationStart());
+ return CONTINUE_OBSERVING;
}
void FromGWSPageLoadMetricsObserver::OnDomContentLoadedEventStart(

Powered by Google App Engine
This is Rietveld 408576698