Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2369793002: WIP: Propagate SurfaceID up window tree hierarchy

Created:
4 years, 2 months ago by Fady Samuel
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, blink-reviews-platform-graphics_chromium.org, nasko+codewatch_chromium.org, yzshen+watch_chromium.org, sievers+watch_chromium.org, Stephen Chennney, yusukes+watch_chromium.org, darin (slow to review), krit, drott+blinkwatch_chromium.org, jam, Justin Novosad, abarth-chromium, jbauman+watch_chromium.org, nona+watch_chromium.org, Rik, darin-cc_chromium.org, blink-reviews, kalyank, rwlbuis, ajuma+watch_chromium.org, mlamouri+watch-content_chromium.org, dshwang, creis+watch_chromium.org, jbroman, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, rjkroege, Ian Vollick, tfarina, shuchen+watch_chromium.org, Aaron Boodman, f(malita), danakj+watch_chromium.org, James Su
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WIP: Propagate SurfaceID up window tree hierarchy BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Patch Set 1 #

Patch Set 2 : Move SurfaceSequenceGenerator to cc/surfaces #

Patch Set 3 : Plumb surface ID to clients #

Patch Set 4 : Broken #

Patch Set 5 : Container Windows submit compositor frames in client lib #

Patch Set 6 : Things render but totally misplaced! #

Patch Set 7 : DrawWindowTree should begin at the active root window for the user #

Patch Set 8 : Things show up in the right place. Input events don't work #

Patch Set 9 : OnChildWindowSurfaceCreated seems dead. Add SatisfySequence #

Patch Set 10 : Fix input events: EventDispatcher ignores container windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1196 lines, -747 lines) Patch
M ash/mus/bridge/wm_shell_mus.cc View 1 2 3 4 1 chunk +6 lines, -1 line 0 comments Download
M ash/mus/bridge/wm_window_mus.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M ash/mus/non_client_frame_controller.h View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -0 lines 0 comments Download
M ash/mus/non_client_frame_controller.cc View 1 2 3 4 5 6 7 8 3 chunks +32 lines, -0 lines 0 comments Download
M ash/mus/root_window_controller.cc View 1 2 3 4 5 6 7 3 chunks +3 lines, -0 lines 0 comments Download
M cc/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M cc/ipc/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/ipc/cc_param_traits.h View 1 chunk +11 lines, -0 lines 0 comments Download
M cc/ipc/cc_param_traits.cc View 4 chunks +43 lines, -1 line 0 comments Download
M cc/ipc/cc_param_traits_macros.h View 1 chunk +1 line, -1 line 0 comments Download
A + cc/ipc/frame_sink_id.mojom View 1 chunk +3 lines, -3 lines 0 comments Download
A cc/ipc/frame_sink_id.typemap View 1 chunk +11 lines, -0 lines 0 comments Download
A cc/ipc/frame_sink_id_struct_traits.h View 1 chunk +31 lines, -0 lines 0 comments Download
M cc/ipc/surface_id.mojom View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/ipc/surface_id_struct_traits.h View 1 chunk +9 lines, -2 lines 0 comments Download
M cc/ipc/surface_sequence.mojom View 1 chunk +3 lines, -1 line 0 comments Download
M cc/ipc/surface_sequence_struct_traits.h View 2 chunks +6 lines, -3 lines 0 comments Download
M cc/ipc/typemaps.gni View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/surface_layer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download
M cc/surfaces/direct_compositor_frame_sink.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/surfaces/display.h View 3 chunks +3 lines, -2 lines 0 comments Download
M cc/surfaces/display.cc View 3 chunks +4 lines, -4 lines 0 comments Download
A cc/surfaces/frame_sink_id.h View 1 chunk +58 lines, -0 lines 0 comments Download
M cc/surfaces/surface.h View 2 chunks +2 lines, -1 line 0 comments Download
M cc/surfaces/surface.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/surfaces/surface_factory.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M cc/surfaces/surface_id.h View 2 chunks +21 lines, -14 lines 0 comments Download
M cc/surfaces/surface_id_allocator.h View 1 chunk +8 lines, -3 lines 0 comments Download
M cc/surfaces/surface_id_allocator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/surfaces/surface_manager.h View 6 chunks +46 lines, -21 lines 0 comments Download
M cc/surfaces/surface_manager.cc View 11 chunks +67 lines, -57 lines 0 comments Download
M cc/surfaces/surface_sequence.h View 3 chunks +10 lines, -8 lines 0 comments Download
A + cc/surfaces/surface_sequence_generator.h View 1 3 chunks +10 lines, -6 lines 0 comments Download
A + cc/surfaces/surface_sequence_generator.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M cc/test/test_compositor_frame_sink.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host.h View 2 chunks +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_in_process.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_in_process.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/surface_sequence_generator.h View 1 1 chunk +0 lines, -37 lines 0 comments Download
M cc/trees/surface_sequence_generator.cc View 1 1 chunk +0 lines, -19 lines 0 comments Download
M components/exo/surface.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/compositor/surface_utils.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/compositor/surface_utils.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/cross_process_frame_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 8 chunks +21 lines, -22 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/delegated_frame_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/delegated_frame_host.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/offscreen_canvas_surface_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_input_event_router.h View 3 chunks +8 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_input_event_router.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +5 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/render_widget.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/render_widget.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M services/ui/public/cpp/tests/test_window_tree.h View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/public/cpp/tests/test_window_tree.cc View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -0 lines 0 comments Download
M services/ui/public/cpp/window.h View 1 2 3 4 5 7 chunks +26 lines, -2 lines 0 comments Download
M services/ui/public/cpp/window.cc View 1 2 3 4 5 6 7 8 9 5 chunks +114 lines, -3 lines 0 comments Download
M services/ui/public/cpp/window_observer.h View 1 2 3 4 5 6 7 8 1 chunk +7 lines, -0 lines 0 comments Download
M services/ui/public/cpp/window_private.h View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M services/ui/public/cpp/window_tree_client.h View 1 2 3 4 5 6 7 8 4 chunks +16 lines, -2 lines 0 comments Download
M services/ui/public/cpp/window_tree_client.cc View 1 2 3 4 5 6 7 8 4 chunks +29 lines, -6 lines 0 comments Download
M services/ui/public/interfaces/surface.mojom View 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/public/interfaces/window_manager.mojom View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/public/interfaces/window_tree.mojom View 1 2 3 4 5 6 7 8 3 chunks +12 lines, -0 lines 0 comments Download
M services/ui/surfaces/BUILD.gn View 1 chunk +3 lines, -2 lines 0 comments Download
A + services/ui/surfaces/compositor_frame_sink.h View 4 chunks +20 lines, -17 lines 0 comments Download
A + services/ui/surfaces/compositor_frame_sink.cc View 4 chunks +27 lines, -22 lines 0 comments Download
M services/ui/surfaces/display_compositor.h View 1 chunk +36 lines, -60 lines 0 comments Download
M services/ui/surfaces/display_compositor.cc View 1 chunk +12 lines, -125 lines 0 comments Download
A services/ui/surfaces/display_compositor_client.h View 1 chunk +24 lines, -0 lines 0 comments Download
D services/ui/surfaces/surfaces_state.h View 1 chunk +0 lines, -49 lines 0 comments Download
D services/ui/surfaces/surfaces_state.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M services/ui/ws/display.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/display.cc View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
M services/ui/ws/display_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/frame_generator.h View 4 5 6 7 8 4 chunks +8 lines, -6 lines 0 comments Download
M services/ui/ws/frame_generator.cc View 1 2 3 4 5 6 7 8 9 9 chunks +45 lines, -49 lines 0 comments Download
M services/ui/ws/frame_generator_delegate.h View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M services/ui/ws/platform_display.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/platform_display.cc View 1 2 3 4 5 6 3 chunks +7 lines, -2 lines 0 comments Download
M services/ui/ws/platform_display_delegate.h View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M services/ui/ws/platform_display_init_params.h View 2 chunks +4 lines, -3 lines 0 comments Download
M services/ui/ws/platform_display_init_params.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/server_window.h View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/ws/server_window.cc View 1 2 3 4 5 6 7 8 9 1 chunk +7 lines, -0 lines 0 comments Download
M services/ui/ws/server_window_delegate.h View 2 chunks +4 lines, -2 lines 0 comments Download
M services/ui/ws/server_window_surface.h View 1 2 6 7 8 9 2 chunks +2 lines, -1 line 0 comments Download
M services/ui/ws/server_window_surface.cc View 1 2 3 4 5 6 7 8 9 3 chunks +9 lines, -7 lines 0 comments Download
M services/ui/ws/server_window_surface_manager.h View 1 2 3 4 5 6 7 8 3 chunks +9 lines, -0 lines 0 comments Download
M services/ui/ws/server_window_surface_manager.cc View 1 2 3 4 5 6 7 8 4 chunks +27 lines, -3 lines 0 comments Download
M services/ui/ws/window_finder.cc View 1 2 3 4 5 6 7 8 9 2 chunks +4 lines, -5 lines 0 comments Download
M services/ui/ws/window_server.h View 1 2 6 chunks +14 lines, -3 lines 0 comments Download
M services/ui/ws/window_server.cc View 1 2 3 4 6 chunks +35 lines, -3 lines 0 comments Download
M services/ui/ws/window_tree.h View 1 2 3 4 5 6 7 8 2 chunks +9 lines, -0 lines 0 comments Download
M services/ui/ws/window_tree.cc View 1 2 3 4 5 6 7 8 3 chunks +26 lines, -0 lines 0 comments Download
M services/ui/ws/window_tree_host_factory.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/compositor.h View 3 chunks +5 lines, -4 lines 0 comments Download
M ui/compositor/compositor.cc View 4 chunks +21 lines, -20 lines 0 comments Download
M ui/compositor/test/context_factories_for_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/test/in_process_context_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/test/in_process_context_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/mus/native_widget_mus.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 2 3 4 5 6 7 8 5 chunks +29 lines, -0 lines 0 comments Download
M ui/views/mus/surface_context_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/surface_context_factory.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (2 generated)
Fady Samuel
Description was changed from ========== WIP: Propagate SurfaceID up window tree hierarchy BUG= ========== to ...
4 years, 2 months ago (2016-09-25 15:18:11 UTC) #1
Fady Samuel
4 years, 2 months ago (2016-09-25 15:18:12 UTC) #2 
Description was changed from

==========
WIP: Propagate SurfaceID up window tree hierarchy

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
WIP: Propagate SurfaceID up window tree hierarchy

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

Powered by Google App Engine
This is Rietveld 408576698