Fix android depfiles to always list GN's outputs[0]

Fix android depfiles to always list GN's outputs[0]

Ninja complains with:
expected depfile 'foo.d' to mention 'bar', got 'baz'

Running ninja twice now reports "no work to do" again.

This change required updating all calls to build_utils.WriteDepFile() so
that the output is passed in. While doing this, I also made the helper
add in GetPythonDependencies() by default.

build/android/gyp/ant.py I just deleted rather than updating since it's
GYP-only.

BUG=646165
Committed: https://crrev.com/4eb18a55cde4daf2ef43330d0304ec73ef546f96
Cr-Commit-Position: refs/heads/master@{#418455}

[agrieve, 2016-09-13 20:39:55]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 20:40:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agrieve, 2016-09-13 20:40:38]

agrieve@chromium.org changed reviewers:
+ dpranke@chromium.org, mef@chromium.org

[agrieve, 2016-09-13 20:40:38]

dpranke - Please review main changes

mef - Please review cronet/

[mef, 2016-09-13 20:46:15]

lgtm

[Dirk Pranke, 2016-09-13 21:03:20]

lgtm.

[jbudorick, 2016-09-13 21:43:26]

jbudorick@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2016-09-13 21:43:27]

https://codereview.chromium.org/2336173003/diff/1/build/android/gyp/util/buil...
File build/android/gyp/util/build_utils.py (right):

https://codereview.chromium.org/2336173003/diff/1/build/android/gyp/util/buil...
build/android/gyp/util/build_utils.py:434:
depfile.write(first_gn_output.replace(' ', '\\ '))
Heads up: this broke the (currently experimental) android_cronet bot:
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...

though it didn't break any of the other android bots.

[commit-bot: I haz the power, 2016-09-13 22:08:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 22:08:09]

Dry run: This issue passed the CQ dry run.

[agrieve, 2016-09-14 00:16:10]

On 2016/09/13 21:43:27, jbudorick wrote:
>
https://codereview.chromium.org/2336173003/diff/1/build/android/gyp/util/buil...
> File build/android/gyp/util/build_utils.py (right):
> 
>
https://codereview.chromium.org/2336173003/diff/1/build/android/gyp/util/buil...
> build/android/gyp/util/build_utils.py:434:
> depfile.write(first_gn_output.replace(' ', '\\ '))
> Heads up: this broke the (currently experimental) android_cronet bot:
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...
> 
> though it didn't break any of the other android bots.

Thanks John! I'll get that fixed up.

[agrieve, 2016-09-14 00:26:30]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-09-14 00:26:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, mef@chromium.org
Link to the patchset: https://codereview.chromium.org/2336173003/#ps20001
(title: "fix cronet_package")

[commit-bot: I haz the power, 2016-09-14 00:27:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 02:04:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-14 02:06:28]

Description was changed from

==========
Fix android depfiles to always list GN's outputs[0]

Ninja complains with:
expected depfile 'foo.d' to mention 'bar', got 'baz'

Running ninja twice now reports "no work to do" again.

This change required updating all calls to build_utils.WriteDepFile() so
that the output is passed in. While doing this, I also made the helper
add in GetPythonDependencies() by default.

build/android/gyp/ant.py I just deleted rather than updating since it's
GYP-only.

BUG=646165
==========

to

==========
Fix android depfiles to always list GN's outputs[0]

Ninja complains with:
expected depfile 'foo.d' to mention 'bar', got 'baz'

Running ninja twice now reports "no work to do" again.

This change required updating all calls to build_utils.WriteDepFile() so
that the output is passed in. While doing this, I also made the helper
add in GetPythonDependencies() by default.

build/android/gyp/ant.py I just deleted rather than updating since it's
GYP-only.

BUG=646165

Committed: https://crrev.com/4eb18a55cde4daf2ef43330d0304ec73ef546f96
Cr-Commit-Position: refs/heads/master@{#418455}
==========

[commit-bot: I haz the power, 2016-09-14 02:06:29]

Patchset 2 (id:??) landed as
https://crrev.com/4eb18a55cde4daf2ef43330d0304ec73ef546f96
Cr-Commit-Position: refs/heads/master@{#418455}