Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: components/cronet/android/BUILD.gn

Issue 2336173003: Fix android depfiles to always list GN's outputs[0] (Closed)
Patch Set: fix cronet_package Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/protoc_java.py ('k') | components/cronet/tools/extract_from_jars.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/BUILD.gn
diff --git a/components/cronet/android/BUILD.gn b/components/cronet/android/BUILD.gn
index cde4b92cec31a091cd97fd541b8e2e0aa2806ffb..9cd1f00f5d733faeb56922c4de7597ae91cee4df 100644
--- a/components/cronet/android/BUILD.gn
+++ b/components/cronet/android/BUILD.gn
@@ -763,8 +763,10 @@ action("extract_cronet_jars") {
"$root_out_dir/lib.java/net/android/net_java.jar",
"$root_out_dir/lib.java/url/url_java.jar",
]
+
+ _stamp_file = "$target_gen_dir/$target_name.stamp"
outputs = [
- depfile,
+ _stamp_file,
]
_rebased_sources = rebase_path(sources, root_build_dir)
@@ -775,6 +777,8 @@ action("extract_cronet_jars") {
"--jars=${_rebased_sources}",
"--depfile",
rebase_path(depfile, root_build_dir),
+ "--stamp",
+ rebase_path(_stamp_file, root_build_dir),
]
deps = [
@@ -872,8 +876,9 @@ action("generate_licenses") {
action("generate_javadoc") {
script = "//components/cronet/tools/generate_javadoc.py"
depfile = "$target_gen_dir/$target_name.d"
+ _stamp_file = "$target_gen_dir/$target_name.stamp"
outputs = [
- depfile,
+ _stamp_file,
]
args = [
"--output-dir",
@@ -886,6 +891,8 @@ action("generate_javadoc") {
rebase_path("//components/cronet/README.md", root_build_dir),
"--depfile",
rebase_path(depfile, root_build_dir),
+ "--stamp",
+ rebase_path(_stamp_file, root_build_dir),
"--lib-java-dir",
rebase_path("$root_build_dir/lib.java/components/cronet/android",
root_build_dir),
« no previous file with comments | « build/protoc_java.py ('k') | components/cronet/tools/extract_from_jars.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698