Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Side by Side Diff: build/config/zip.gni

Issue 2336173003: Fix android depfiles to always list GN's outputs[0] (Closed)
Patch Set: fix cronet_package Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/android/internal_rules.gni ('k') | build/protoc_java.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Creates a zip archive of the inputs. 5 # Creates a zip archive of the inputs.
6 # 6 #
7 # inputs (required) 7 # inputs (required)
8 # List of input files relative to the current directory. 8 # List of input files relative to the current directory.
9 # 9 #
10 # output (required) 10 # output (required)
11 # File name to write. 11 # File name to write.
12 # 12 #
13 # base_dir (optional) 13 # base_dir (optional)
14 # If provided, the archive paths will be relative to this directory. 14 # If provided, the archive paths will be relative to this directory.
15 # 15 #
16 # deps, public_deps, data_deps, testonly, visibility (optional) 16 # deps, public_deps, data_deps, testonly, visibility (optional)
17 # Normal meaning. 17 # Normal meaning.
18 template("zip") { 18 template("zip") {
19 action(target_name) { 19 action(target_name) {
20 script = "//build/android/gn/zip.py" 20 script = "//build/android/gn/zip.py"
21 depfile = "$target_gen_dir/$target_name.d" 21 depfile = "$target_gen_dir/$target_name.d"
22 inputs = invoker.inputs 22 inputs = invoker.inputs
23 outputs = [ 23 outputs = [
24 depfile,
25 invoker.output, 24 invoker.output,
26 ] 25 ]
27 26
28 assert(defined(invoker.inputs)) 27 assert(defined(invoker.inputs))
29 rebase_inputs = rebase_path(invoker.inputs, root_build_dir) 28 rebase_inputs = rebase_path(invoker.inputs, root_build_dir)
30 29
31 assert(defined(invoker.output)) 30 assert(defined(invoker.output))
32 rebase_output = rebase_path(invoker.output, root_build_dir) 31 rebase_output = rebase_path(invoker.output, root_build_dir)
33 32
34 args = [ 33 args = [
(...skipping 12 matching lines...) Expand all
47 forward_variables_from(invoker, 46 forward_variables_from(invoker,
48 [ 47 [
49 "testonly", 48 "testonly",
50 "deps", 49 "deps",
51 "public_deps", 50 "public_deps",
52 "data_deps", 51 "data_deps",
53 "visibility", 52 "visibility",
54 ]) 53 ])
55 } 54 }
56 } 55 }
OLDNEW
« no previous file with comments | « build/config/android/internal_rules.gni ('k') | build/protoc_java.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698