Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3125)

Unified Diff: build/protoc_java.py

Issue 2336173003: Fix android depfiles to always list GN's outputs[0] (Closed)
Patch Set: fix cronet_package Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/zip.gni ('k') | components/cronet/android/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/protoc_java.py
diff --git a/build/protoc_java.py b/build/protoc_java.py
index 470667c1f4bff9d7d1b130db2d5435bfda0d26d5..46fa8200ebd596cd2c26b4f1f2c8c2868597b361 100755
--- a/build/protoc_java.py
+++ b/build/protoc_java.py
@@ -57,9 +57,9 @@ def main(argv):
build_utils.ZipDir(options.srcjar, temp_dir)
if options.depfile:
- build_utils.WriteDepfile(
- options.depfile,
- args + [options.protoc] + build_utils.GetPythonDependencies())
+ assert options.srcjar
+ deps = args + [options.protoc]
+ build_utils.WriteDepfile(options.depfile, options.srcjar, deps)
if options.stamp:
build_utils.Touch(options.stamp)
« no previous file with comments | « build/config/zip.gni ('k') | components/cronet/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698