Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: components/cronet/tools/jar_src.py

Issue 2336173003: Fix android depfiles to always list GN's outputs[0] (Closed)
Patch Set: fix cronet_package Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/tools/generate_javadoc.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/tools/jar_src.py
diff --git a/components/cronet/tools/jar_src.py b/components/cronet/tools/jar_src.py
index 91f3cd17167f09860c9ebf6b4ff05f525d930b55..09281ab93c266e88f7e77cf3156d15935c4bc4b8 100755
--- a/components/cronet/tools/jar_src.py
+++ b/components/cronet/tools/jar_src.py
@@ -71,12 +71,12 @@ def main():
JarSources(src_dir, options.jar_path)
if options.depfile:
- input_paths = []
+ deps = []
for src_dir in src_dirs:
for root, _, filenames in os.walk(src_dir):
- input_paths.extend(os.path.join(root, f) for f in filenames)
- build_utils.WriteDepfile(options.depfile,
- input_paths + build_utils.GetPythonDependencies())
+ deps.extend(os.path.join(root, f) for f in filenames)
+ build_utils.WriteDepfile(options.depfile, options.jar_path, deps)
+
# Clean up temporary output directory.
if unzipped_jar_path:
build_utils.DeleteDirectory(unzipped_jar_path)
« no previous file with comments | « components/cronet/tools/generate_javadoc.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698