build/android/gyp/pack_relocations.py - Issue 2336173003: Fix android depfiles to always list GN's outputs[0]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/pack_relocations.py

Issue 2336173003: Fix android depfiles to always list GN's outputs[0] (Closed)

Patch Set: fix cronet_package Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/gyp/pack_relocations.py

diff --git a/build/android/gyp/pack_relocations.py b/build/android/gyp/pack_relocations.py

index c2d02d72c054b11ee1a160ac8d25b9a0c3c6715f..6b0f8f1284e59bb628195d24d3432f2eacec36db 100755

--- a/build/android/gyp/pack_relocations.py

+++ b/build/android/gyp/pack_relocations.py

@@ -90,11 +90,10 @@ def main(args):

if options.filelistjson:

build_utils.WriteJson({ 'files': output_paths }, options.filelistjson)

+ output_paths.append(options.filelistjson)

if options.depfile:

- build_utils.WriteDepfile(

- options.depfile,

- libraries + build_utils.GetPythonDependencies())

+ build_utils.WriteDepfile(options.depfile, output_paths[-1], libraries)

if options.stamp:

build_utils.Touch(options.stamp)

« no previous file with comments | « build/android/gyp/locale_pak_resources.py ('k') | build/android/gyp/util/build_utils.py » ('j') | no next file with comments »