build/android/incremental_install/generate_android_manifest.py - Issue 2336173003: Fix android depfiles to always list GN's outputs[0]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/incremental_install/generate_android_manifest.py

Issue 2336173003: Fix android depfiles to always list GN's outputs[0] (Closed)

Patch Set: fix cronet_package Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/incremental_install/generate_android_manifest.py

diff --git a/build/android/incremental_install/generate_android_manifest.py b/build/android/incremental_install/generate_android_manifest.py

index 163b4c34be4b06992d9f4e1cf0112b9627f2ebc8..2ead34f323bb04fc0b069ae423f635d5e85c971a 100755

--- a/build/android/incremental_install/generate_android_manifest.py

+++ b/build/android/incremental_install/generate_android_manifest.py

@@ -101,9 +101,8 @@ def main():

f.write(new_manifest_data)

if options.depfile:

- build_utils.WriteDepfile(

- options.depfile,

- [options.src_manifest] + build_utils.GetPythonDependencies())

+ deps = [options.src_manifest]

+ build_utils.WriteDepfile(options.depfile, options.out_manifest, deps)

if __name__ == '__main__':