build/android/gyp/write_build_config.py - Issue 2336173003: Fix android depfiles to always list GN's outputs[0]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/write_build_config.py

Issue 2336173003: Fix android depfiles to always list GN's outputs[0] (Closed)

Patch Set: fix cronet_package Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/gyp/write_build_config.py

diff --git a/build/android/gyp/write_build_config.py b/build/android/gyp/write_build_config.py

index d121f7d8e01b556f924ca02fc04da7a199edb3f0..c17bfcb45906717c585940668da6dae9f34eb147 100755

--- a/build/android/gyp/write_build_config.py

+++ b/build/android/gyp/write_build_config.py

@@ -337,7 +337,7 @@ def main(argv):

options.type)

deps = Deps(direct_deps_config_paths)

- all_inputs = deps.AllConfigPaths() + build_utils.GetPythonDependencies()

+ all_inputs = deps.AllConfigPaths()

# Remove other locale resources if there is alternative_locale_resource in

# direct deps.

@@ -662,7 +662,7 @@ def main(argv):

build_utils.WriteJson(config, options.build_config, only_if_changed=True)

if options.depfile:

- build_utils.WriteDepfile(options.depfile, all_inputs)

+ build_utils.WriteDepfile(options.depfile, options.build_config, all_inputs)

if __name__ == '__main__':

« no previous file with comments | « build/android/gyp/util/build_utils.py ('k') | build/android/gyp/write_ordered_libraries.py » ('j') | no next file with comments »