Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Unified Diff: components/cronet/tools/generate_javadoc.py

Issue 2336173003: Fix android depfiles to always list GN's outputs[0] (Closed)
Patch Set: fix cronet_package Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/tools/extract_from_jars.py ('k') | components/cronet/tools/jar_src.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/tools/generate_javadoc.py
diff --git a/components/cronet/tools/generate_javadoc.py b/components/cronet/tools/generate_javadoc.py
index 7eb3bac656693ac76dcd8ca3da094b2153016fab..3914b91ed235643cbecda7911d1e3ebce6bdf5d6 100755
--- a/components/cronet/tools/generate_javadoc.py
+++ b/components/cronet/tools/generate_javadoc.py
@@ -57,6 +57,7 @@ def main():
parser.add_option('--overview-file', help='Path of the overview page')
parser.add_option('--readme-file', help='Path of the README.md')
parser.add_option('--lib-java-dir', help='Directory containing java libs')
+ parser.add_option('--stamp', help='Path to touch on success.')
options, _ = parser.parse_args()
# A temporary directory to put the output of cronet api source jar files.
@@ -72,12 +73,14 @@ def main():
GenerateJavadoc(options, os.path.abspath(unzipped_jar_path))
+ if options.stamp:
+ build_utils.Touch(options.stamp)
if options.depfile:
- input_paths = []
+ assert options.stamp
+ deps = []
for root, _, filenames in os.walk(options.input_dir):
- input_paths.extend(os.path.join(root, f) for f in filenames)
- build_utils.WriteDepfile(options.depfile,
- input_paths + build_utils.GetPythonDependencies())
+ deps.extend(os.path.join(root, f) for f in filenames)
+ build_utils.WriteDepfile(options.depfile, options.stamp, deps)
# Clean up temporary output directory.
build_utils.DeleteDirectory(unzipped_jar_path)
« no previous file with comments | « components/cronet/tools/extract_from_jars.py ('k') | components/cronet/tools/jar_src.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698