Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: components/cronet/tools/extract_from_jars.py

Issue 2336173003: Fix android depfiles to always list GN's outputs[0] (Closed)
Patch Set: fix cronet_package Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/android/BUILD.gn ('k') | components/cronet/tools/generate_javadoc.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/tools/extract_from_jars.py
diff --git a/components/cronet/tools/extract_from_jars.py b/components/cronet/tools/extract_from_jars.py
index ee32b940fec703af7aba9b9ef26f1cd8d739d184..ccddea417ca0ee2efe2df013bfa256ee4d770c08 100755
--- a/components/cronet/tools/extract_from_jars.py
+++ b/components/cronet/tools/extract_from_jars.py
@@ -40,8 +40,8 @@ def main():
ExtractJars(options)
if options.depfile:
- build_utils.WriteDepfile(options.depfile,
- build_utils.GetPythonDependencies())
+ assert options.stamp
+ build_utils.WriteDepfile(options.depfile, options.stamp)
if options.stamp:
build_utils.Touch(options.stamp)
« no previous file with comments | « components/cronet/android/BUILD.gn ('k') | components/cronet/tools/generate_javadoc.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698