build/android/gyp/copy_ex.py - Issue 2336173003: Fix android depfiles to always list GN's outputs[0]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/copy_ex.py

Issue 2336173003: Fix android depfiles to always list GN's outputs[0] (Closed)

Patch Set: fix cronet_package Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/gyp/copy_ex.py

diff --git a/build/android/gyp/copy_ex.py b/build/android/gyp/copy_ex.py

index 8103a93b1ba023b595b1f664c30146fbabe7c617..196cbcc288e1aa50bc3bdbe91b62a14343fdc992 100755

--- a/build/android/gyp/copy_ex.py

+++ b/build/android/gyp/copy_ex.py

@@ -104,9 +104,8 @@ def main(args):

DoRenaming(options, deps)

if options.depfile:

- build_utils.WriteDepfile(

- options.depfile,

- deps + build_utils.GetPythonDependencies())

+ assert options.stamp

+ build_utils.WriteDepfile(options.depfile, options.stamp, deps)

if options.stamp:

build_utils.Touch(options.stamp)

« no previous file with comments | « build/android/gyp/ant.py ('k') | build/android/gyp/create_dist_jar.py » ('j') | no next file with comments »