Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 22850006: Replace uses of GrAssert by SkASSERT. (Closed)

Created:
7 years, 4 months ago by tfarina
Modified:
7 years, 4 months ago
CC:
skia-review_googlegroups.com, bsalomon
Visibility:
Public.

Description

Replace uses of GrAssert by SkASSERT. R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=10789

Patch Set 1 #

Patch Set 2 : src/gpu #

Patch Set 3 : gpu/effects #

Patch Set 4 : gpu/gl #

Patch Set 5 : the rest #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+925 lines, -927 lines) Patch
M experimental/AndroidPathRenderer/GrAndroidPathRenderer.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M experimental/StrokePathRenderer/GrStrokePathRenderer.cpp View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M include/gpu/GrBackendEffectFactory.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrColor.h View 3 chunks +6 lines, -6 lines 0 comments Download
M include/gpu/GrConfig.h View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M include/gpu/GrContext.h View 1 2 3 4 5 5 chunks +6 lines, -6 lines 0 comments Download
M include/gpu/GrDrawEffect.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/gpu/GrEffect.h View 4 chunks +5 lines, -5 lines 0 comments Download
M include/gpu/GrEffectStage.h View 5 chunks +7 lines, -7 lines 0 comments Download
M include/gpu/GrPaint.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/gpu/GrRenderTarget.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrResource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/gpu/GrSurface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/gpu/GrTBackendEffectFactory.h View 1 chunk +4 lines, -4 lines 0 comments Download
M include/gpu/GrTexture.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/gpu/GrTextureAccess.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrTypes.h View 6 chunks +7 lines, -7 lines 0 comments Download
M include/gpu/GrTypesPriv.h View 5 chunks +5 lines, -5 lines 0 comments Download
M include/gpu/gl/GrGLExtensions.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/gl/SkGLContextHelper.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkXfermode.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 2 3 4 5 10 chunks +20 lines, -20 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrAllocPool.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrAllocator.h View 1 6 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/GrAtlas.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAtlas.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrBinHashKey.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrBlend.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrBufferAllocPool.cpp View 1 17 chunks +33 lines, -33 lines 0 comments Download
M src/gpu/GrClipMaskCache.h View 1 8 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 18 chunks +21 lines, -21 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 16 chunks +23 lines, -24 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 1 6 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/GrDrawState.h View 1 10 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 1 9 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 3 4 5 4 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 20 chunks +46 lines, -46 lines 0 comments Download
M src/gpu/GrEffect.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrGpu.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGpu.cpp View 1 17 chunks +24 lines, -24 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 2 3 4 5 17 chunks +30 lines, -30 lines 0 comments Download
M src/gpu/GrMemoryPool.cpp View 1 6 chunks +23 lines, -23 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrPaint.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPathRenderer.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrPathRendererChain.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPathUtils.cpp View 1 6 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/GrPlotMgr.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrRectanizer.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrRectanizer.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/GrRectanizer_fifo.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/GrRedBlackTree.h View 1 35 chunks +106 lines, -106 lines 0 comments Download
M src/gpu/GrResource.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrResourceCache.cpp View 1 9 chunks +24 lines, -24 lines 0 comments Download
M src/gpu/GrStencil.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrStencilAndCoverPathRenderer.cpp View 1 4 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/GrStencilBuffer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTBSearch.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTHashCache.h View 1 4 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrTextContext.cpp View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrTextStrike.cpp View 1 2 3 4 5 7 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/GrTextStrike_impl.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrTexture.cpp View 1 3 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/GrTextureAccess.cpp View 1 4 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 11 chunks +11 lines, -11 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGrFontScaler.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.h View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrTextureDomainEffect.cpp View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrTextureStripAtlas.cpp View 1 2 9 chunks +25 lines, -25 lines 0 comments Download
M src/gpu/gl/GrGLBufferImpl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLBufferImpl.cpp View 1 2 3 5 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 2 3 4 5 7 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/gl/GrGLCreateNullInterface.cpp View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLEffect.cpp View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLEffectMatrix.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLEffectMatrix.cpp View 1 2 3 3 chunks +11 lines, -11 lines 0 comments Download
M src/gpu/gl/GrGLIRect.h View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLIndexBuffer.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLPath.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 2 3 10 chunks +14 lines, -14 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLRenderTarget.cpp View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLSL.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLSL.cpp View 1 2 3 7 chunks +14 lines, -14 lines 0 comments Download
M src/gpu/gl/GrGLSL_impl.h View 1 2 3 10 chunks +23 lines, -23 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.h View 1 2 3 4 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 1 2 3 14 chunks +16 lines, -16 lines 0 comments Download
M src/gpu/gl/GrGLShaderVar.h View 1 2 3 7 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLTexture.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLUniformManager.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLUniformManager.cpp View 1 2 3 15 chunks +44 lines, -44 lines 0 comments Download
M src/gpu/gl/GrGLUtil.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLVertexArray.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLVertexArray.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLVertexBuffer.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 3 35 chunks +44 lines, -44 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 1 2 3 10 chunks +17 lines, -17 lines 0 comments Download
M src/gpu/gl/debug/GrDebugGL.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/debug/GrDebugGL.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gr_unittests.cpp View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
trivial search-and-replace. ptal. thanks.
7 years, 4 months ago (2013-08-16 14:11:24 UTC) #1
bsalomon
lgtm
7 years, 4 months ago (2013-08-16 14:16:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/22850006/12001
7 years, 4 months ago (2013-08-16 14:16:26 UTC) #3
commit-bot: I haz the power
Retried try job too often on Build-Mac10.7-Clang-x86-Release-Trybot for step(s) BuildBench, BuildGm, BuildMost, BuildSkiaLib, BuildTests, BuildTools ...
7 years, 4 months ago (2013-08-16 15:55:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/22850006/12001
7 years, 4 months ago (2013-08-16 17:13:02 UTC) #5
commit-bot: I haz the power
Failed to apply patch for src/gpu/GrAAHairLinePathRenderer.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 4 months ago (2013-08-16 17:14:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/22850006/23001
7 years, 4 months ago (2013-08-16 22:15:18 UTC) #7
tfarina
7 years, 4 months ago (2013-08-17 00:04:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #6 manually as r10789 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698