Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2268993003: [Command Buffer] Coding style: FrameBuffer -> Framebuffer to be comformant (Closed)

Created:
4 years, 3 months ago by yunchao
Modified:
4 years, 3 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Command Buffer] Coding style: FrameBuffer -> Framebuffer to be comformant BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/4656783ba4a9e4b76eae6f2ad0392c45bca9df69 Cr-Commit-Position: refs/heads/master@{#414288}

Patch Set 1 #

Patch Set 2 : fix build issue: frame_buffer_* -> framebuffer_* #

Patch Set 3 : fix build issues: some components depend on gpu command buffer #

Patch Set 4 : code rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -196 lines) Patch
M android_webview/browser/aw_gl_surface.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/aw_gl_surface.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 9 chunks +10 lines, -10 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 6 chunks +9 lines, -9 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_autogen.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 1 2 11 chunks +15 lines, -15 lines 0 comments Download
M gpu/command_buffer/service/gl_surface_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 55 chunks +98 lines, -98 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 2 3 10 chunks +10 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_autogen.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 4 chunks +13 lines, -13 lines 0 comments Download
M media/gpu/rendering_helper.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gl/gl_surface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gl/gl_surface.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/gl/scoped_binders.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/gl/scoped_binders.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gl/yuv_to_rgb_converter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surface.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surface.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 66 (54 generated)
yunchao
In Graphics area, we usually use Framebuffer, instead of FrameBuffer or Frame Buffer. In Chromium ...
4 years, 3 months ago (2016-08-24 14:23:54 UTC) #36
Zhenyao Mo
On 2016/08/24 14:23:54, yunchao wrote: > In Graphics area, we usually use Framebuffer, instead of ...
4 years, 3 months ago (2016-08-24 15:59:08 UTC) #37
DaleCurtis
media/ lgtm
4 years, 3 months ago (2016-08-24 16:54:16 UTC) #38
Ken Russell (switch to Gerrit)
ui/gl lgtm
4 years, 3 months ago (2016-08-24 18:23:12 UTC) #39
Zhenyao Mo
+boliu: android_webview owner +rjkroege: ui/ozone owner
4 years, 3 months ago (2016-08-24 22:15:52 UTC) #41
boliu
lgtm
4 years, 3 months ago (2016-08-24 22:16:54 UTC) #42
rjkroege
ui/ozone lgtm
4 years, 3 months ago (2016-08-24 22:41:15 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268993003/120001
4 years, 3 months ago (2016-08-24 23:08:56 UTC) #45
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/245423)
4 years, 3 months ago (2016-08-24 23:20:59 UTC) #47
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268993003/140001
4 years, 3 months ago (2016-08-25 03:21:07 UTC) #62
commit-bot: I haz the power
Committed patchset #4 (id:140001)
4 years, 3 months ago (2016-08-25 03:28:32 UTC) #64
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 03:30:17 UTC) #66
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4656783ba4a9e4b76eae6f2ad0392c45bca9df69
Cr-Commit-Position: refs/heads/master@{#414288}

Powered by Google App Engine
This is Rietveld 408576698