gpu/command_buffer/service/feature_info.cc - Issue 2268993003: [Command Buffer] Coding style: FrameBuffer -> Framebuffer to be comformant

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/feature_info.cc

Issue 2268993003: [Command Buffer] Coding style: FrameBuffer -> Framebuffer to be comformant (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: code rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h ('k') | gpu/command_buffer/service/feature_info_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/feature_info.cc

diff --git a/gpu/command_buffer/service/feature_info.cc b/gpu/command_buffer/service/feature_info.cc

index 60ab77e6837552aadb56f96b66d0cf5f35a5d78a..6e81ab67bb16f6c40c3775b676c2420785689b79 100644

--- a/gpu/command_buffer/service/feature_info.cc

+++ b/gpu/command_buffer/service/feature_info.cc

@@ -569,7 +569,7 @@ void FeatureInfo::InitializeFeatures() {

validators_.texture_format.AddValue(GL_SRGB_EXT);

validators_.texture_format.AddValue(GL_SRGB_ALPHA_EXT);

validators_.render_buffer_format.AddValue(GL_SRGB8_ALPHA8_EXT);

- validators_.frame_buffer_parameter.AddValue(

+ validators_.framebuffer_parameter.AddValue(

GL_FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING_EXT);

validators_.texture_unsized_internal_format.AddValue(GL_SRGB_EXT);

validators_.texture_unsized_internal_format.AddValue(GL_SRGB_ALPHA_EXT);

@@ -863,8 +863,8 @@ void FeatureInfo::InitializeFeatures() {

gl_version_info_->is_es3 || gl_version_info_->is_desktop_core_profile;

if (ext_has_multisample) {

feature_flags_.chromium_framebuffer_multisample = true;

- validators_.frame_buffer_target.AddValue(GL_READ_FRAMEBUFFER_EXT);

- validators_.frame_buffer_target.AddValue(GL_DRAW_FRAMEBUFFER_EXT);

+ validators_.framebuffer_target.AddValue(GL_READ_FRAMEBUFFER_EXT);

+ validators_.framebuffer_target.AddValue(GL_DRAW_FRAMEBUFFER_EXT);

validators_.g_l_state.AddValue(GL_READ_FRAMEBUFFER_BINDING_EXT);

validators_.g_l_state.AddValue(GL_MAX_SAMPLES_EXT);

validators_.render_buffer_parameter.AddValue(GL_RENDERBUFFER_SAMPLES_EXT);

@@ -882,7 +882,7 @@ void FeatureInfo::InitializeFeatures() {

validators_.render_buffer_parameter.AddValue(

GL_RENDERBUFFER_SAMPLES_EXT);

validators_.g_l_state.AddValue(GL_MAX_SAMPLES_EXT);

- validators_.frame_buffer_parameter.AddValue(

+ validators_.framebuffer_parameter.AddValue(

GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_SAMPLES_EXT);

AddExtensionString("GL_EXT_multisampled_render_to_texture");

}