Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 2263843002: DevTools: merge devtools target with devtools host, part 1 (Closed)

Created:
4 years, 4 months ago by pfeldman
Modified:
4 years, 3 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, jam, jochen+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: merge devtools target with devtools host, part 1 BUG=627517 TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a Cr-Commit-Position: refs/heads/master@{#414707}

Patch Set 1 #

Patch Set 2 : for review #

Total comments: 13

Patch Set 3 : some review comments #

Patch Set 4 : for bots #

Patch Set 5 : lcean #

Patch Set 6 : all done #

Total comments: 8

Patch Set 7 : tests run #

Patch Set 8 : for landing #

Patch Set 9 : again #

Patch Set 10 : w/ checks #

Patch Set 11 : rolled back extension tests expectations #

Patch Set 12 : fixed headless #

Patch Set 13 : for landing 2 #

Patch Set 14 : for landing 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+760 lines, -880 lines) Patch
M android_webview/browser/aw_dev_tools_discovery_provider.cc View 1 2 3 4 5 2 chunks +5 lines, -21 lines 0 comments Download
M chrome/browser/android/dev_tools_discovery_provider_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 6 chunks +77 lines, -93 lines 0 comments Download
M chrome/browser/devtools/chrome_devtools_discovery_provider.cc View 1 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/devtools/chrome_devtools_manager_delegate.h View 1 2 3 4 5 6 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/devtools/chrome_devtools_manager_delegate.cc View 1 2 3 4 5 6 7 3 chunks +92 lines, -10 lines 0 comments Download
M chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/devtools/device/devtools_android_bridge.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/devtools/device/devtools_android_bridge.cc View 1 2 3 4 5 6 7 8 9 10 11 12 10 chunks +165 lines, -161 lines 0 comments Download
M chrome/browser/devtools/devtools_target_impl.h View 1 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/browser/devtools/devtools_target_impl.cc View 1 2 chunks +1 line, -201 lines 0 comments Download
M chrome/browser/devtools/devtools_targets_ui.cc View 1 3 chunks +18 lines, -14 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_api.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +21 lines, -18 lines 0 comments Download
M chrome/browser/resources/inspect/inspect.js View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/inspect_ui.h View 1 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui.cc View 1 6 chunks +12 lines, -10 lines 0 comments Download
M components/devtools_discovery/basic_target_descriptor.h View 1 1 chunk +0 lines, -32 lines 0 comments Download
M components/devtools_discovery/basic_target_descriptor.cc View 1 1 chunk +1 line, -78 lines 0 comments Download
M components/devtools_discovery/devtools_discovery_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/devtools_discovery/devtools_target_descriptor.h View 1 2 1 chunk +0 lines, -33 lines 0 comments Download
M components/devtools_http_handler/devtools_http_handler.cc View 1 8 chunks +17 lines, -15 lines 0 comments Download
M content/browser/devtools/browser_devtools_agent_host.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/devtools/browser_devtools_agent_host.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +12 lines, -3 lines 0 comments Download
M content/browser/devtools/devtools_agent_host_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +8 lines, -5 lines 0 comments Download
M content/browser/devtools/devtools_agent_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 6 chunks +43 lines, -12 lines 0 comments Download
M content/browser/devtools/devtools_manager_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +26 lines, -8 lines 0 comments Download
M content/browser/devtools/forwarding_agent_host.h View 1 2 13 1 chunk +7 lines, -1 line 0 comments Download
M content/browser/devtools/forwarding_agent_host.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +20 lines, -7 lines 0 comments Download
M content/browser/devtools/protocol/browser_handler.cc View 3 chunks +1 line, -24 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/service_worker_handler.cc View 1 2 3 chunks +2 lines, -22 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.h View 1 2 3 4 5 7 8 9 10 11 1 chunk +8 lines, -1 line 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 7 chunks +57 lines, -9 lines 0 comments Download
M content/browser/devtools/service_worker_devtools_agent_host.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/devtools/service_worker_devtools_agent_host.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/devtools/service_worker_devtools_manager.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/devtools/shared_worker_devtools_agent_host.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/devtools/shared_worker_devtools_agent_host.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/devtools/site_per_process_devtools_browsertest.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/devtools/worker_devtools_agent_host.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_internals_ui.cc View 1 2 3 4 5 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/devtools_agent_host.h View 1 2 3 4 5 6 7 4 chunks +30 lines, -20 lines 0 comments Download
M content/public/browser/devtools_external_agent_proxy_delegate.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +37 lines, -7 lines 0 comments Download
M content/public/browser/devtools_manager_delegate.h View 1 2 3 4 5 6 2 chunks +10 lines, -2 lines 0 comments Download
M content/shell/browser/shell_devtools_manager_delegate.h View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M content/shell/browser/shell_devtools_manager_delegate.cc View 1 2 3 4 5 6 1 chunk +9 lines, -0 lines 0 comments Download
M headless/lib/browser/headless_devtools_manager_delegate.h View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M headless/lib/browser/headless_devtools_manager_delegate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js View 1 2 3 4 5 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 67 (47 generated)
dgozman
https://codereview.chromium.org/2263843002/diff/20001/chrome/browser/android/dev_tools_discovery_provider_android.cc File chrome/browser/android/dev_tools_discovery_provider_android.cc (right): https://codereview.chromium.org/2263843002/diff/20001/chrome/browser/android/dev_tools_discovery_provider_android.cc#newcode226 chrome/browser/android/dev_tools_discovery_provider_android.cc:226: result.push_back(TabDescriptor::CreateForUnloadedTab( This should be a forwarding agent host. https://codereview.chromium.org/2263843002/diff/20001/chrome/browser/devtools/chrome_devtools_manager_delegate.cc ...
4 years, 4 months ago (2016-08-22 23:09:07 UTC) #3
pfeldman
all done
4 years, 4 months ago (2016-08-23 21:04:42 UTC) #13
dgozman
lgtm https://codereview.chromium.org/2263843002/diff/100001/chrome/browser/android/dev_tools_discovery_provider_android.cc File chrome/browser/android/dev_tools_discovery_provider_android.cc (right): https://codereview.chromium.org/2263843002/diff/100001/chrome/browser/android/dev_tools_discovery_provider_android.cc#newcode214 chrome/browser/android/dev_tools_discovery_provider_android.cc:214: tab->GetAndroidId(), tab->GetTitle(), tab->GetURL())); style: indentation https://codereview.chromium.org/2263843002/diff/100001/chrome/browser/devtools/chrome_devtools_manager_delegate.cc File chrome/browser/devtools/chrome_devtools_manager_delegate.cc ...
4 years, 4 months ago (2016-08-23 23:48:31 UTC) #17
pfeldman
All done except for: https://codereview.chromium.org/2263843002/diff/100001/content/browser/devtools/render_frame_devtools_agent_host.cc File content/browser/devtools/render_frame_devtools_agent_host.cc (right): https://codereview.chromium.org/2263843002/diff/100001/content/browser/devtools/render_frame_devtools_agent_host.cc#newcode882 content/browser/devtools/render_frame_devtools_agent_host.cc:882: std::string RenderFrameDevToolsAgentHost::GetType() { On 2016/08/23 ...
4 years, 4 months ago (2016-08-24 00:22:33 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263843002/160001
4 years, 4 months ago (2016-08-24 00:38:22 UTC) #22
pfeldman
+ asargent@chromium.org for extensions OWNERS + skyostil@google.com for headless OWNERS those are all mechanical changes.
4 years, 4 months ago (2016-08-24 00:40:35 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/244446)
4 years, 4 months ago (2016-08-24 00:47:46 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263843002/200001
4 years, 4 months ago (2016-08-24 22:02:18 UTC) #40
commit-bot: I haz the power
Committed patchset #11 (id:200001)
4 years, 4 months ago (2016-08-24 23:59:11 UTC) #42
commit-bot: I haz the power
Patchset 11 (id:??) landed as https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79 Cr-Commit-Position: refs/heads/master@{#414208}
4 years, 4 months ago (2016-08-25 00:02:24 UTC) #44
mohsen
A revert of this CL (patchset #11 id:200001) has been created in https://codereview.chromium.org/2277473007/ by mohsen@chromium.org. ...
4 years, 4 months ago (2016-08-25 01:52:57 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263843002/220001
4 years, 4 months ago (2016-08-25 02:07:48 UTC) #49
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263843002/240001
4 years, 3 months ago (2016-08-25 19:44:00 UTC) #53
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/214082)
4 years, 3 months ago (2016-08-25 20:14:18 UTC) #55
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263843002/260001
4 years, 3 months ago (2016-08-26 02:04:43 UTC) #58
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/269331)
4 years, 3 months ago (2016-08-26 04:52:49 UTC) #60
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263843002/260001
4 years, 3 months ago (2016-08-26 13:18:55 UTC) #62
commit-bot: I haz the power
Committed patchset #14 (id:260001)
4 years, 3 months ago (2016-08-26 14:35:34 UTC) #64
commit-bot: I haz the power
Patchset 14 (id:??) landed as https://crrev.com/a9e7ddae8f1174e71c2e999eec4813ee24c1f41a Cr-Commit-Position: refs/heads/master@{#414707}
4 years, 3 months ago (2016-08-26 14:37:29 UTC) #66
sullivan
4 years, 3 months ago (2016-08-29 14:20:52 UTC) #67
Message was sent while issue was closed.
A revert of this CL (patchset #14 id:260001) has been created in
https://codereview.chromium.org/2289773002/ by sullivan@chromium.org.

The reason for reverting is: Caused crashes on all WebView telemetry tests. See
crbug.com/641390..

Powered by Google App Engine
This is Rietveld 408576698