Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: components/devtools_discovery/basic_target_descriptor.h

Issue 2263843002: DevTools: merge devtools target with devtools host, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for landing 3 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/inspect_ui.cc ('k') | components/devtools_discovery/basic_target_descriptor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/devtools_discovery/basic_target_descriptor.h
diff --git a/components/devtools_discovery/basic_target_descriptor.h b/components/devtools_discovery/basic_target_descriptor.h
index a3b834a7e3ad0747d303468db03fb082b26a8a1e..59db1ecc2e96a8fceec3341ea10ccf792bcdd1bf 100644
--- a/components/devtools_discovery/basic_target_descriptor.h
+++ b/components/devtools_discovery/basic_target_descriptor.h
@@ -15,42 +15,10 @@ class BasicTargetDescriptor : public DevToolsTargetDescriptor {
scoped_refptr<content::DevToolsAgentHost> agent_host);
~BasicTargetDescriptor() override;
- static const char kTypePage[];
- static const char kTypeServiceWorker[];
- static const char kTypeSharedWorker[];
- static const char kTypeOther[];
-
- // DevToolsTargetDescriptor implementation.
- std::string GetId() const override;
- std::string GetParentId() const override;
- std::string GetType() const override;
- std::string GetTitle() const override;
- std::string GetDescription() const override;
- GURL GetURL() const override;
- GURL GetFaviconURL() const override;
- base::TimeTicks GetLastActivityTime() const override;
- bool IsAttached() const override;
scoped_refptr<content::DevToolsAgentHost> GetAgentHost() const override;
- bool Activate() const override;
- bool Close() const override;
-
- protected:
- void set_parent_id(const std::string& parent_id) { parent_id_ = parent_id; }
- void set_type(const std::string& type) { type_ = type; }
- void set_title(const std::string& title) { title_ = title; }
- void set_description(const std::string& desc) { description_ = desc; }
- void set_url(const GURL& url) { url_ = url; }
- void set_favicon_url(const GURL& url) { favicon_url_ = url; }
private:
scoped_refptr<content::DevToolsAgentHost> agent_host_;
- std::string parent_id_;
- std::string type_;
- std::string title_;
- std::string description_;
- GURL url_;
- GURL favicon_url_;
- base::TimeTicks last_activity_time_;
};
} // namespace devtools_discovery
« no previous file with comments | « chrome/browser/ui/webui/inspect_ui.cc ('k') | components/devtools_discovery/basic_target_descriptor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698