content/browser/devtools/service_worker_devtools_manager.cc - Issue 2263843002: DevTools: merge devtools target with devtools host, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/service_worker_devtools_manager.cc

Issue 2263843002: DevTools: merge devtools target with devtools host, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 3 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/service_worker_devtools_agent_host.cc ('k') | content/browser/devtools/shared_worker_devtools_agent_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/service_worker_devtools_manager.cc

diff --git a/content/browser/devtools/service_worker_devtools_manager.cc b/content/browser/devtools/service_worker_devtools_manager.cc

index 5796497a1f4161b1515442a4d9c2cc899a1ccec7..9899de9f7c6644a37ccd1b498df15a5e4cc06df3 100644

--- a/content/browser/devtools/service_worker_devtools_manager.cc

+++ b/content/browser/devtools/service_worker_devtools_manager.cc

@@ -117,10 +117,8 @@ void ServiceWorkerDevToolsManager::WorkerReadyForInspection(

WorkerReadyForInspection(host.get()));

// Then bring up UI for the ones not picked by other clients.

- if (host->IsPausedForDebugOnStart() && !host->IsAttached()) {

- host->Inspect(RenderProcessHost::FromID(worker_process_id)->

- GetBrowserContext());

- }

+ if (host->IsPausedForDebugOnStart() && !host->IsAttached())

+ host->Inspect();

}

void ServiceWorkerDevToolsManager::WorkerVersionInstalled(int worker_process_id,