content/shell/browser/shell_devtools_manager_delegate.cc - Issue 2263843002: DevTools: merge devtools target with devtools host, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_devtools_manager_delegate.cc

Issue 2263843002: DevTools: merge devtools target with devtools host, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 3 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/shell_devtools_manager_delegate.h ('k') | headless/lib/browser/headless_devtools_manager_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/shell_devtools_manager_delegate.cc

diff --git a/content/shell/browser/shell_devtools_manager_delegate.cc b/content/shell/browser/shell_devtools_manager_delegate.cc

index b3746c37f7008a30aa3f243b1dcf2007745c18b7..d88618919f3c80f546d910eab46123d565120f6e 100644

--- a/content/shell/browser/shell_devtools_manager_delegate.cc

+++ b/content/shell/browser/shell_devtools_manager_delegate.cc

@@ -236,4 +236,13 @@ base::DictionaryValue* ShellDevToolsManagerDelegate::HandleCommand(

return result.release(); // Caller takes ownership.

}

+std::string ShellDevToolsManagerDelegate::GetTargetType(RenderFrameHost* host) {

+ return DevToolsAgentHost::kTypePage;

+std::string ShellDevToolsManagerDelegate::GetTargetTitle(

+ RenderFrameHost* host) {

+ return "";

} // namespace content