headless/lib/browser/headless_devtools_manager_delegate.h - Issue 2263843002: DevTools: merge devtools target with devtools host, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/lib/browser/headless_devtools_manager_delegate.h

Issue 2263843002: DevTools: merge devtools target with devtools host, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 3 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/shell_devtools_manager_delegate.cc ('k') | headless/lib/browser/headless_devtools_manager_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: headless/lib/browser/headless_devtools_manager_delegate.h

diff --git a/headless/lib/browser/headless_devtools_manager_delegate.h b/headless/lib/browser/headless_devtools_manager_delegate.h

index dbc6a25cd3a626edda61c79bd1e8c9b3e61a10dd..92ddec8d450fb5052393282c660b2f415beb9829 100644

--- a/headless/lib/browser/headless_devtools_manager_delegate.h

+++ b/headless/lib/browser/headless_devtools_manager_delegate.h

@@ -27,12 +27,13 @@ class HeadlessDevToolsManagerDelegate

~HeadlessDevToolsManagerDelegate() override;

// DevToolsManagerDelegate implementation:

- void Inspect(content::BrowserContext* browser_context,

- content::DevToolsAgentHost* agent_host) override {}

+ void Inspect(content::DevToolsAgentHost* agent_host) override {}

void DevToolsAgentStateChanged(content::DevToolsAgentHost* agent_host,

bool attached) override{};

base::DictionaryValue* HandleCommand(content::DevToolsAgentHost* agent_host,

base::DictionaryValue* command) override;

+ std::string GetTargetType(content::RenderFrameHost* host) override;

+ std::string GetTargetTitle(content::RenderFrameHost* host) override;

private:

std::unique_ptr<base::Value> CreateTarget(