content/browser/devtools/render_frame_devtools_agent_host.h - Issue 2263843002: DevTools: merge devtools target with devtools host, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.h

Issue 2263843002: DevTools: merge devtools target with devtools host, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 3 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/protocol/service_worker_handler.cc ('k') | content/browser/devtools/render_frame_devtools_agent_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/render_frame_devtools_agent_host.h

diff --git a/content/browser/devtools/render_frame_devtools_agent_host.h b/content/browser/devtools/render_frame_devtools_agent_host.h

index d43b978f384932449e5afa328cbd6bccaa06bfc4..c7b1925ec514f09e2e31ca32de1c13514a00c45f 100644

--- a/content/browser/devtools/render_frame_devtools_agent_host.h

+++ b/content/browser/devtools/render_frame_devtools_agent_host.h

@@ -81,11 +81,18 @@ class CONTENT_EXPORT RenderFrameDevToolsAgentHost

void ConnectWebContents(WebContents* web_contents) override;

BrowserContext* GetBrowserContext() override;

WebContents* GetWebContents() override;

- Type GetType() override;

+ std::string GetParentId() override;

+ std::string GetType() override;

std::string GetTitle() override;

+ std::string GetDescription() override;

GURL GetURL() override;

+ GURL GetFaviconURL() override;

bool Activate() override;

+ void Reload() override;

bool Close() override;

+ base::TimeTicks GetLastActivityTime() override;

bool DispatchProtocolMessage(const std::string& message) override;

private: