Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: content/browser/devtools/devtools_manager_unittest.cc

Issue 2263843002: DevTools: merge devtools target with devtools host, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for landing 3 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_manager_unittest.cc
diff --git a/content/browser/devtools/devtools_manager_unittest.cc b/content/browser/devtools/devtools_manager_unittest.cc
index 2461179ae87fb2fe1500ae83a2e26e17a8d170f0..70b3fa5f7f9164ee77379270dba16cf469a12178 100644
--- a/content/browser/devtools/devtools_manager_unittest.cc
+++ b/content/browser/devtools/devtools_manager_unittest.cc
@@ -6,6 +6,7 @@
#include <memory>
+#include "base/guid.h"
#include "base/location.h"
#include "base/macros.h"
#include "base/run_loop.h"
@@ -209,6 +210,19 @@ TEST_F(DevToolsManagerTest, ReattachOnCancelPendingNavigation) {
}
class TestExternalAgentDelegate: public DevToolsExternalAgentProxyDelegate {
+ public:
+ TestExternalAgentDelegate() : id_(base::GenerateGUID()) {
+ }
+ ~TestExternalAgentDelegate() override {
+ expectEvent(1, "Attach");
+ expectEvent(1, "Detach");
+ expectEvent(0, "SendMessageToBackend.message0");
+ expectEvent(1, "SendMessageToBackend.message1");
+ expectEvent(2, "SendMessageToBackend.message2");
+ }
+
+ private:
+ std::string id_;
std::map<std::string,int> event_counter_;
void recordEvent(const std::string& name) {
@@ -227,18 +241,22 @@ class TestExternalAgentDelegate: public DevToolsExternalAgentProxyDelegate {
void Detach() override { recordEvent("Detach"); };
+ std::string GetId() override { return id_; }
+ std::string GetType() override { return ""; }
+ std::string GetTitle() override { return ""; }
+ std::string GetDescription() override { return ""; }
+ GURL GetURL() override { return GURL(); }
+ GURL GetFaviconURL() override { return GURL(); }
+
+ bool Activate() override { return false; };
+ bool Inspect() override { return false; };
+ void Reload() override { };
+ bool Close() override { return false; };
+
void SendMessageToBackend(const std::string& message) override {
recordEvent(std::string("SendMessageToBackend.") + message);
};
- public :
- ~TestExternalAgentDelegate() override {
- expectEvent(1, "Attach");
- expectEvent(1, "Detach");
- expectEvent(0, "SendMessageToBackend.message0");
- expectEvent(1, "SendMessageToBackend.message1");
- expectEvent(2, "SendMessageToBackend.message2");
- }
};
TEST_F(DevToolsManagerTest, TestExternalProxy) {
« no previous file with comments | « content/browser/devtools/devtools_agent_host_impl.cc ('k') | content/browser/devtools/forwarding_agent_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698