Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: chrome/browser/devtools/chrome_devtools_manager_delegate.cc

Issue 2263843002: DevTools: merge devtools target with devtools host, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for landing 3 Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/devtools/chrome_devtools_manager_delegate.h" 5 #include "chrome/browser/devtools/chrome_devtools_manager_delegate.h"
6 6
7 #include "base/strings/utf_string_conversions.h"
7 #include "build/build_config.h" 8 #include "build/build_config.h"
8 #include "chrome/browser/devtools/devtools_network_protocol_handler.h" 9 #include "chrome/browser/devtools/devtools_network_protocol_handler.h"
9 #include "components/devtools_discovery/devtools_discovery_manager.h" 10 #include "components/devtools_discovery/devtools_discovery_manager.h"
11 #include "content/public/browser/devtools_agent_host.h"
12 #include "content/public/browser/web_contents.h"
10 13
11 #if !defined(OS_ANDROID) 14 #if !defined(OS_ANDROID)
12 #include "chrome/browser/devtools/devtools_window.h" 15 #include "chrome/browser/devtools/devtools_window.h"
16 #include "chrome/browser/extensions/extension_tab_util.h"
13 #include "chrome/browser/profiles/profile.h" 17 #include "chrome/browser/profiles/profile.h"
14 #include "content/public/browser/devtools_agent_host.h" 18 #include "chrome/browser/ui/tab_contents/tab_contents_iterator.h"
19 #include "content/public/browser/render_frame_host.h"
20 #include "extensions/browser/extension_host.h"
21 #include "extensions/browser/extension_registry.h"
22 #include "extensions/browser/process_manager.h"
23 #else // !defined(OS_ANDROID)
24 #include "chrome/browser/android/tab_android.h"
25 #include "chrome/browser/ui/android/tab_model/tab_model.h"
26 #include "chrome/browser/ui/android/tab_model/tab_model_list.h"
15 #endif // !defined(OS_ANDROID) 27 #endif // !defined(OS_ANDROID)
16 28
17 using devtools_discovery::DevToolsDiscoveryManager; 29 using devtools_discovery::DevToolsDiscoveryManager;
18 30
31 char ChromeDevToolsManagerDelegate::kTypeApp[] = "app";
32 char ChromeDevToolsManagerDelegate::kTypeBackgroundPage[] = "background_page";
33
19 ChromeDevToolsManagerDelegate::ChromeDevToolsManagerDelegate() 34 ChromeDevToolsManagerDelegate::ChromeDevToolsManagerDelegate()
20 : network_protocol_handler_(new DevToolsNetworkProtocolHandler()) { 35 : network_protocol_handler_(new DevToolsNetworkProtocolHandler()) {
21 } 36 }
22 37
23 ChromeDevToolsManagerDelegate::~ChromeDevToolsManagerDelegate() { 38 ChromeDevToolsManagerDelegate::~ChromeDevToolsManagerDelegate() {
24 } 39 }
25 40
26 void ChromeDevToolsManagerDelegate::Inspect( 41 void ChromeDevToolsManagerDelegate::Inspect(
27 content::BrowserContext* browser_context,
28 content::DevToolsAgentHost* agent_host) { 42 content::DevToolsAgentHost* agent_host) {
29 #if !defined(OS_ANDROID) 43 #if !defined(OS_ANDROID)
30 Profile* profile = Profile::FromBrowserContext(browser_context); 44 Profile* profile =
45 Profile::FromBrowserContext(agent_host->GetBrowserContext());
31 if (!profile) 46 if (!profile)
32 return; 47 return;
33 content::DevToolsAgentHost::Type type = agent_host->GetType(); 48 std::string type = agent_host->GetType();
34 if (type == content::DevToolsAgentHost::TYPE_SHARED_WORKER || 49 if (type == content::DevToolsAgentHost::kTypeSharedWorker ||
35 type == content::DevToolsAgentHost::TYPE_SERVICE_WORKER) { 50 type == content::DevToolsAgentHost::kTypeServiceWorker) {
36 DevToolsWindow::OpenDevToolsWindowForWorker(profile, agent_host); 51 DevToolsWindow::OpenDevToolsWindowForWorker(profile, agent_host);
37 return; 52 return;
38 } 53 }
39 if (type == content::DevToolsAgentHost::TYPE_WEB_CONTENTS) { 54 content::WebContents* web_contents = agent_host->GetWebContents();
40 content::WebContents* web_contents = agent_host->GetWebContents(); 55 if (web_contents)
41 DCHECK(web_contents);
42 DevToolsWindow::OpenDevToolsWindow(web_contents); 56 DevToolsWindow::OpenDevToolsWindow(web_contents);
43 }
44 #endif // !defined(OS_ANDROID) 57 #endif // !defined(OS_ANDROID)
45 } 58 }
46 59
47 base::DictionaryValue* ChromeDevToolsManagerDelegate::HandleCommand( 60 base::DictionaryValue* ChromeDevToolsManagerDelegate::HandleCommand(
48 content::DevToolsAgentHost* agent_host, 61 content::DevToolsAgentHost* agent_host,
49 base::DictionaryValue* command_dict) { 62 base::DictionaryValue* command_dict) {
50 std::unique_ptr<base::DictionaryValue> result = 63 std::unique_ptr<base::DictionaryValue> result =
51 DevToolsDiscoveryManager::GetInstance()->HandleCreateTargetCommand( 64 DevToolsDiscoveryManager::GetInstance()->HandleCreateTargetCommand(
52 command_dict); 65 command_dict);
53 if (result) 66 if (result)
54 return result.release(); // Caller takes ownership. 67 return result.release(); // Caller takes ownership.
55 return network_protocol_handler_->HandleCommand(agent_host, command_dict); 68 return network_protocol_handler_->HandleCommand(agent_host, command_dict);
56 } 69 }
57 70
71 std::string ChromeDevToolsManagerDelegate::GetTargetType(
72 content::RenderFrameHost* host) {
73 content::WebContents* web_contents =
74 content::WebContents::FromRenderFrameHost(host);
75 #if !defined(OS_ANDROID)
76 for (TabContentsIterator it; !it.done(); it.Next()) {
77 if (*it == web_contents)
78 return content::DevToolsAgentHost::kTypePage;
79 }
80
81 if (host->GetParent())
82 return content::DevToolsAgentHost::kTypeFrame;
83
84 const extensions::Extension* extension = extensions::ExtensionRegistry::Get(
85 web_contents->GetBrowserContext())->enabled_extensions().GetByID(
86 host->GetLastCommittedURL().host());
87 if (!extension)
88 return content::DevToolsAgentHost::kTypeOther;
89
90 Profile* profile =
91 Profile::FromBrowserContext(web_contents->GetBrowserContext());
92 if (!profile)
93 return content::DevToolsAgentHost::kTypeOther;
94
95 extensions::ExtensionHost* extension_host =
96 extensions::ProcessManager::Get(profile)
97 ->GetBackgroundHostForExtension(extension->id());
98 if (extension_host &&
99 extension_host->host_contents() == web_contents) {
100 return kTypeBackgroundPage;
101 } else if (extension->is_hosted_app()
102 || extension->is_legacy_packaged_app()
103 || extension->is_platform_app()) {
104 return kTypeApp;
105 }
106 #else // !defined(OS_ANDROID)
107 for (TabModelList::const_iterator iter = TabModelList::begin();
108 iter != TabModelList::end(); ++iter) {
109 TabModel* model = *iter;
110 for (int i = 0; i < model->GetTabCount(); ++i) {
111 TabAndroid* tab = model->GetTabAt(i);
112 if (tab && web_contents == tab->web_contents())
113 return content::DevToolsAgentHost::kTypePage;
114 }
115 }
116 #endif // !defined(OS_ANDROID)
117 return content::DevToolsAgentHost::kTypeOther;
118 }
119
120 std::string ChromeDevToolsManagerDelegate::GetTargetTitle(
121 content::RenderFrameHost* host) {
122 #if !defined(OS_ANDROID)
123 content::WebContents* web_contents =
124 content::WebContents::FromRenderFrameHost(host);
125 if (host->GetParent())
126 return host->GetLastCommittedURL().spec();
127 for (TabContentsIterator it; !it.done(); it.Next()) {
128 if (*it == web_contents)
129 return base::UTF16ToUTF8(web_contents->GetTitle());
130 }
131 const extensions::Extension* extension = extensions::ExtensionRegistry::Get(
132 web_contents->GetBrowserContext())->enabled_extensions().GetByID(
133 host->GetLastCommittedURL().host());
134 if (extension)
135 return extension->name();
136 #endif // !defined(OS_ANDROID)
137 return "";
138 }
139
58 void ChromeDevToolsManagerDelegate::DevToolsAgentStateChanged( 140 void ChromeDevToolsManagerDelegate::DevToolsAgentStateChanged(
59 content::DevToolsAgentHost* agent_host, 141 content::DevToolsAgentHost* agent_host,
60 bool attached) { 142 bool attached) {
61 network_protocol_handler_->DevToolsAgentStateChanged(agent_host, attached); 143 network_protocol_handler_->DevToolsAgentStateChanged(agent_host, attached);
62 } 144 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698